cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(language-service): keep analyzedModules cache when source files don't change (#32562)

Browse Source 
This change will improve performance of language service when working in external templates.

PR Close #32562
This commit is contained in:
Andrius 2019-09-09 20:51:31 +03:00 committed by Matias Niemelä
parent 53dbff66d7
commit 4f033235b1
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/language-service/src/typescript_host.ts
View File

@ -275,12 +275,14 @@ export class TypeScriptServiceHost implements LanguageServiceHost {
// Invalidate file that have changed in the static symbol resolver // Invalidate file that have changed in the static symbol resolver
const seen = new Set<string>(); const seen = new Set<string>();
let hasChanges = false;
for (const sourceFile of program.getSourceFiles()) { for (const sourceFile of program.getSourceFiles()) {
const fileName = sourceFile.fileName; const fileName = sourceFile.fileName;
seen.add(fileName); seen.add(fileName);
const version = this.tsLsHost.getScriptVersion(fileName); const version = this.tsLsHost.getScriptVersion(fileName);
const lastVersion = this.fileVersions.get(fileName); const lastVersion = this.fileVersions.get(fileName);
if (version !== lastVersion) { if (version !== lastVersion) {
hasChanges = true;
this.fileVersions.set(fileName, version); this.fileVersions.set(fileName, version);
this.staticSymbolResolver.invalidateFile(fileName); this.staticSymbolResolver.invalidateFile(fileName);
} }
@ -295,7 +297,7 @@ export class TypeScriptServiceHost implements LanguageServiceHost {
this.lastProgram = program; this.lastProgram = program;
return false; return missing.length === 0 && !hasChanges;
} }
/** /**

10
packages/language-service/test/typescript_host_spec.ts
View File

@ -148,4 +148,14 @@ describe('TypeScriptServiceHost', () => {
expect(newModules.ngModuleByPipeOrDirective.has(helloComp)).toBe(true); expect(newModules.ngModuleByPipeOrDirective.has(helloComp)).toBe(true);
expect(newModules.ngModuleByPipeOrDirective.has(appComp)).toBe(false); expect(newModules.ngModuleByPipeOrDirective.has(appComp)).toBe(false);
}); });
it('should not clear caches when external template changes', () => {
const tsLSHost = new MockTypescriptHost(['/app/main.ts'], toh);
const tsLS = ts.createLanguageService(tsLSHost);
const ngLSHost = new TypeScriptServiceHost(tsLSHost, tsLS);
const oldModules = ngLSHost.getAnalyzedModules();
tsLSHost.override('/app/test.ng', '<div></div>');
const newModules = ngLSHost.getAnalyzedModules();
expect(newModules).toBe(oldModules);
});
}); });