perf(render): don't create property setters if not needed

This commit is contained in:
Tobias Bosch
2015-06-10 10:31:38 -07:00
parent 24e647e0f7
commit 4f27611ae6
5 changed files with 87 additions and 29 deletions

View File

@ -142,7 +142,7 @@ class Html5LibDomAdapter implements DomAdapter {
throw 'not implemented';
}
getText(el) {
throw 'not implemented';
return el.text;
}
setText(el, String value) => el.text = value;
@ -183,7 +183,8 @@ class Html5LibDomAdapter implements DomAdapter {
clone(node) => node.clone(true);
hasProperty(element, String name) {
throw 'not implemented';
// This is needed for serverside compile to generate the right getters/setters...
return true;
}
getElementsByClassName(element, String name) {
throw 'not implemented';

View File

@ -205,7 +205,7 @@ export class Parse5DomAdapter extends DomAdapter {
getText(el) {
if (this.isTextNode(el)) {
return el.data;
} else if (el.childNodes.length == 0) {
} else if (isBlank(el.childNodes) || el.childNodes.length == 0) {
return "";
} else {
var textContent = "";