build: should use $(execpath) in npm_package_bin args (#34736)

This is recommended in the Bazel docs as $(location) is ambiguous and can mean either $(execpath) or $(rootpath) depending on the context.

PR Close #34736
This commit is contained in:
Greg Magolan
2020-01-08 02:08:00 -08:00
committed by Matias Niemelä
parent 8560f016cd
commit 51a9f6c540
3 changed files with 11 additions and 11 deletions

View File

@ -70,14 +70,14 @@ html_insert_assets(
outs = ["_/index.html"],
args = [
"--html",
"$(location :index.html)",
"$(execpath :index.html)",
"--out",
"$@",
"--roots",
"$(RULEDIR)",
"--assets",
"$(location :global_stylesheet.css)",
"$(location @npm//:node_modules/zone.js/dist/zone.min.js)",
"$(execpath :global_stylesheet.css)",
"$(execpath @npm//:node_modules/zone.js/dist/zone.min.js)",
"bundle.min.js",
],
data = [