cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(service-worker): avoid network requests when looking up hashed resources in cache (#24127)

Browse Source 
PR Close #24127
This commit is contained in:
George Kalpakas
2018-05-25 15:15:42 +03:00
committed by Miško Hevery
parent 45feb10c46
commit 52d43a99ef
2 changed files with 55 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/service-worker/worker/src/app-version.ts
View File

@ -198,8 +198,6 @@ export class AppVersion implements UpdateSource {
* Check this version for a given resource with a particular hash.
*/
async lookupResourceWithHash(url: string, hash: string): Promise<Response|null> {
const req = this.adapter.newRequest(url);
// Verify that this version has the requested resource cached. If not,
// there's no point in trying.
if (!this.hashTable.has(url)) {
@ -208,16 +206,12 @@ export class AppVersion implements UpdateSource {
// Next, check whether the resource has the correct hash. If not, any cached
// response isn't usable.
if (this.hashTable.get(url) ! !== hash) {
if (this.hashTable.get(url) !== hash) {
return null;
}
// TODO: no-op context and appropriate contract. Currently this is a violation
// of the typings and could cause issues if handleFetch() has side effects. A
// better strategy to deal with side effects is needed.
// TODO: this could result in network fetches if the response is lazy. Refactor
// to avoid them.
return this.handleFetch(req, null !);
const cacheState = await this.lookupResourceWithoutHash(url);
return cacheState && cacheState.response;
}
/**