From 53be85a7fb070b5a1961fa8f124513c72ffffc5f Mon Sep 17 00:00:00 2001 From: Brandon Roberts Date: Sun, 16 Jul 2017 13:24:33 -0500 Subject: [PATCH] docs(aio): Updated usage of Observables in router guide. Added section for advanced redirects (#18197) PR Close #18197 --- aio/content/examples/router/e2e-spec.ts | 4 +- aio/content/examples/router/src/app.css | 4 + .../router/src/app/app-routing.module.ts | 2 +- .../router/src/app/app.component.6.ts | 23 + .../examples/router/src/app/app.component.ts | 2 +- .../src/app/can-deactivate-guard.service.1.ts | 5 +- .../crisis-detail-resolver.service.ts | 9 +- .../crisis-detail.component.1.ts | 10 +- .../crisis-center/crisis-detail.component.ts | 5 +- .../crisis-center/crisis-list.component.1.ts | 33 +- .../crisis-center/crisis-list.component.ts | 37 +- .../src/app/crisis-center/crisis.service.ts | 17 +- .../examples/router/src/app/dialog.service.ts | 13 +- .../src/app/heroes/hero-detail.component.1.ts | 10 +- .../src/app/heroes/hero-detail.component.2.ts | 8 +- .../src/app/heroes/hero-detail.component.ts | 16 +- .../src/app/heroes/hero-list.component.1.ts | 22 +- .../src/app/heroes/hero-list.component.ts | 28 +- .../router/src/app/heroes/hero.service.ts | 13 +- .../src/app/heroes/heroes-routing.module.1.ts | 24 + .../src/app/heroes/heroes-routing.module.ts | 8 +- aio/content/guide/router.md | 461 ++++++++---------- 22 files changed, 380 insertions(+), 374 deletions(-) create mode 100644 aio/content/examples/router/src/app/app.component.6.ts create mode 100644 aio/content/examples/router/src/app/heroes/heroes-routing.module.1.ts diff --git a/aio/content/examples/router/e2e-spec.ts b/aio/content/examples/router/e2e-spec.ts index e7a882f83c..91c2e253d8 100644 --- a/aio/content/examples/router/e2e-spec.ts +++ b/aio/content/examples/router/e2e-spec.ts @@ -12,13 +12,13 @@ describe('Router', () => { beforeAll(() => browser.get('')); function getPageStruct() { - const hrefEles = element.all(by.css('my-app a')); + const hrefEles = element.all(by.css('my-app > nav a')); const crisisDetail = element.all(by.css('my-app > ng-component > ng-component > ng-component > div')).first(); const heroDetail = element(by.css('my-app > ng-component > div')); return { hrefs: hrefEles, - activeHref: element(by.css('my-app a.active')), + activeHref: element(by.css('my-app > nav a.active')), crisisHref: hrefEles.get(0), crisisList: element.all(by.css('my-app > ng-component > ng-component li')), diff --git a/aio/content/examples/router/src/app.css b/aio/content/examples/router/src/app.css index 26e161dd30..8da7fa6567 100644 --- a/aio/content/examples/router/src/app.css +++ b/aio/content/examples/router/src/app.css @@ -15,6 +15,10 @@ height: 1.6em; border-radius: 4px; } +.items li a { + display: block; + text-decoration: none; +} .items li:hover { color: #607D8B; background-color: #DDD; diff --git a/aio/content/examples/router/src/app/app-routing.module.ts b/aio/content/examples/router/src/app/app-routing.module.ts index 17ba610edc..be5dd1d5c9 100644 --- a/aio/content/examples/router/src/app/app-routing.module.ts +++ b/aio/content/examples/router/src/app/app-routing.module.ts @@ -28,7 +28,7 @@ const appRoutes: Routes = [ data: { preload: true } }, // #enddocregion preload-v2 - { path: '', redirectTo: '/heroes', pathMatch: 'full' }, + { path: '', redirectTo: '/superheroes', pathMatch: 'full' }, { path: '**', component: PageNotFoundComponent } ]; diff --git a/aio/content/examples/router/src/app/app.component.6.ts b/aio/content/examples/router/src/app/app.component.6.ts new file mode 100644 index 0000000000..a479680cbe --- /dev/null +++ b/aio/content/examples/router/src/app/app.component.6.ts @@ -0,0 +1,23 @@ +// #docplaster +// #docregion +import { Component } from '@angular/core'; + +@Component({ + selector: 'my-app', + // #docregion template + template: ` +

Angular Router

+ + + + ` + // #enddocregion template +}) +export class AppComponent { +} diff --git a/aio/content/examples/router/src/app/app.component.ts b/aio/content/examples/router/src/app/app.component.ts index a479680cbe..32be0c4d70 100644 --- a/aio/content/examples/router/src/app/app.component.ts +++ b/aio/content/examples/router/src/app/app.component.ts @@ -9,7 +9,7 @@ import { Component } from '@angular/core';

Angular Router