fix(ivy): NgOnChangesFeature no longer included in hello_world (#28187)

- Wraps the NgOnChangesFeature in a factory such that no side effects occur in the module root
- Adds comments to ngInherit property on feature definition interface to help guide others not to make the same mistake
- Updates compiler to generate the feature properly after the change to it being a factory
- Updates appropriate tests

PR Close #28187

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -80,9 +80,6 @@
   {
     "name": "NO_PARENT_INJECTOR"
   },
-  {
-    "name": "NgOnChangesFeature"
-  },
   {
     "name": "NodeInjectorFactory"
   },
@@ -104,12 +101,6 @@
   {
     "name": "SANITIZER"
   },
-  {
-    "name": "SIMPLE_CHANGES_STORE"
-  },
-  {
-    "name": "SimpleChange"
-  },
   {
     "name": "TVIEW"
   },
@@ -308,9 +299,6 @@
   {
     "name": "getRootView"
   },
-  {
-    "name": "getSimpleChangesStore"
-  },
   {
     "name": "hasParentInjector"
   },
@@ -368,9 +356,6 @@
   {
     "name": "nextNgElementId"
   },
-  {
-    "name": "ngOnChangesSetInput"
-  },
   {
     "name": "noSideEffects"
   },
@@ -440,9 +425,6 @@
   {
     "name": "setPreviousOrParentTNode"
   },
-  {
-    "name": "setSimpleChangesStore"
-  },
   {
     "name": "setTNodeAndViewData"
   },
@@ -460,8 +442,5 @@
   },
   {
     "name": "viewAttached"
-  },
-  {
-    "name": "wrapOnChanges"
   }
 ]

packages/core/test/bundling/injection/bundle.golden_symbols.json

@@ -8,9 +8,6 @@
   {
     "name": "EMPTY_ARRAY"
   },
-  {
-    "name": "EMPTY_OBJ"
-  },
   {
     "name": "EmptyErrorImpl"
   },
@@ -38,9 +35,6 @@
   {
     "name": "NULL_INJECTOR"
   },
-  {
-    "name": "NgOnChangesFeature"
-  },
   {
     "name": "NullInjector"
   },
@@ -56,18 +50,12 @@
   {
     "name": "R3Injector"
   },
-  {
-    "name": "SIMPLE_CHANGES_STORE"
-  },
   {
     "name": "ScopedService"
   },
   {
     "name": "Self"
   },
-  {
-    "name": "SimpleChange"
-  },
   {
     "name": "SkipSelf"
   },
@@ -125,9 +113,6 @@
   {
     "name": "getNullInjector"
   },
-  {
-    "name": "getSimpleChangesStore"
-  },
   {
     "name": "hasDeps"
   },
@@ -170,9 +155,6 @@
   {
     "name": "makeRecord"
   },
-  {
-    "name": "ngOnChangesSetInput"
-  },
   {
     "name": "providerToFactory"
   },
@@ -185,13 +167,7 @@
   {
     "name": "setCurrentInjector"
   },
-  {
-    "name": "setSimpleChangesStore"
-  },
   {
     "name": "stringify"
-  },
-  {
-    "name": "wrapOnChanges"
   }
 ]

packages/core/test/bundling/todo/bundle.golden_symbols.json

@@ -143,9 +143,6 @@
   {
     "name": "NgModuleRef"
   },
-  {
-    "name": "NgOnChangesFeature"
-  },
   {
     "name": "NodeInjector"
   },
@@ -185,9 +182,6 @@
   {
     "name": "SANITIZER"
   },
-  {
-    "name": "SIMPLE_CHANGES_STORE"
-  },
   {
     "name": "SWITCH_ELEMENT_REF_FACTORY"
   },
@@ -197,9 +191,6 @@
   {
     "name": "SWITCH_VIEW_CONTAINER_REF_FACTORY"
   },
-  {
-    "name": "SimpleChange"
-  },
   {
     "name": "SkipSelf"
   },
@@ -785,9 +776,6 @@
   {
     "name": "getRootView"
   },
-  {
-    "name": "getSimpleChangesStore"
-  },
   {
     "name": "getSinglePropIndexValue"
   },
@@ -1016,9 +1004,6 @@
   {
     "name": "nextNgElementId"
   },
-  {
-    "name": "ngOnChangesSetInput"
-  },
   {
     "name": "noSideEffects"
   },
@@ -1187,9 +1172,6 @@
   {
     "name": "setSanitizeFlag"
   },
-  {
-    "name": "setSimpleChangesStore"
-  },
   {
     "name": "setStyle"
   },
@@ -1255,8 +1237,5 @@
   },
   {
     "name": "wrapListenerWithPreventDefault"
-  },
-  {
-    "name": "wrapOnChanges"
   }
 ]