fix(ivy): NgOnChangesFeature no longer included in hello_world (#28187)

- Wraps the NgOnChangesFeature in a factory such that no side effects occur in the module root
- Adds comments to ngInherit property on feature definition interface to help guide others not to make the same mistake
- Updates compiler to generate the feature properly after the change to it being a factory
- Updates appropriate tests

PR Close #28187
This commit is contained in:
Ben Lesh
2019-01-22 11:17:13 -08:00
committed by Alex Rickabaugh
parent a95e81978b
commit 5430d2bc66
13 changed files with 41 additions and 89 deletions

View File

@ -8,9 +8,6 @@
{
"name": "EMPTY_ARRAY"
},
{
"name": "EMPTY_OBJ"
},
{
"name": "EmptyErrorImpl"
},
@ -38,9 +35,6 @@
{
"name": "NULL_INJECTOR"
},
{
"name": "NgOnChangesFeature"
},
{
"name": "NullInjector"
},
@ -56,18 +50,12 @@
{
"name": "R3Injector"
},
{
"name": "SIMPLE_CHANGES_STORE"
},
{
"name": "ScopedService"
},
{
"name": "Self"
},
{
"name": "SimpleChange"
},
{
"name": "SkipSelf"
},
@ -125,9 +113,6 @@
{
"name": "getNullInjector"
},
{
"name": "getSimpleChangesStore"
},
{
"name": "hasDeps"
},
@ -170,9 +155,6 @@
{
"name": "makeRecord"
},
{
"name": "ngOnChangesSetInput"
},
{
"name": "providerToFactory"
},
@ -185,13 +167,7 @@
{
"name": "setCurrentInjector"
},
{
"name": "setSimpleChangesStore"
},
{
"name": "stringify"
},
{
"name": "wrapOnChanges"
}
]