fix(ivy): NgOnChangesFeature no longer included in hello_world (#28187)

- Wraps the NgOnChangesFeature in a factory such that no side effects occur in the module root
- Adds comments to ngInherit property on feature definition interface to help guide others not to make the same mistake
- Updates compiler to generate the feature properly after the change to it being a factory
- Updates appropriate tests

PR Close #28187

packages/core/test/render3/common_with_def.ts

@@ -40,7 +40,7 @@ NgForOf.ngDirectiveDef = defineDirective({
   type: NgTemplateOutletDef,
   selectors: [['', 'ngTemplateOutlet', '']],
   factory: () => new NgTemplateOutletDef(directiveInject(ViewContainerRef as any)),
-  features: [NgOnChangesFeature],
+  features: [NgOnChangesFeature()],
   inputs:
       {ngTemplateOutlet: 'ngTemplateOutlet', ngTemplateOutletContext: 'ngTemplateOutletContext'}
 });

packages/core/test/render3/host_binding_spec.ts

@@ -357,7 +357,7 @@ describe('host bindings', () => {
         template: (rf: RenderFlags, ctx: InitHookComp) => {},
         consts: 0,
         vars: 0,
-        features: [NgOnChangesFeature],
+        features: [NgOnChangesFeature()],
         hostBindings: (rf: RenderFlags, ctx: InitHookComp, elIndex: number) => {
           if (rf & RenderFlags.Create) {
             allocHostVars(1);

packages/core/test/render3/inherit_definition_feature_spec.ts

@@ -501,7 +501,7 @@ describe('InheritDefinitionFeature', () => {
         type: SuperDirective,
         selectors: [['', 'superDir', '']],
         factory: () => new SuperDirective(),
-        features: [NgOnChangesFeature],
+        features: [NgOnChangesFeature()],
         inputs: {someInput: 'someInput'}
       });
     }

packages/core/test/render3/lifecycle_spec.ts

@@ -2008,7 +2008,7 @@ describe('lifecycles', () => {
           vars: vars,
           inputs: {a: 'val1', b: ['publicVal2', 'val2']}, template,
           directives: directives,
-          features: [NgOnChangesFeature],
+          features: [NgOnChangesFeature()],
         });
       };
     }
@@ -2027,7 +2027,7 @@ describe('lifecycles', () => {
         selectors: [['', 'dir', '']],
         factory: () => new Directive(),
         inputs: {a: 'val1', b: ['publicVal2', 'val2']},
-        features: [NgOnChangesFeature],
+        features: [NgOnChangesFeature()],
       });
     }
 
@@ -2732,7 +2732,7 @@ describe('lifecycles', () => {
           vars: vars,
           inputs: {val: 'val'}, template,
           directives: directives,
-          features: [NgOnChangesFeature],
+          features: [NgOnChangesFeature()],
         });
       };
     }

packages/core/test/render3/view_container_ref_spec.ts

@@ -1631,7 +1631,7 @@ describe('ViewContainerRef', () => {
             textBinding(0, interpolation1('', cmp.name, ''));
           }
         },
-        features: [NgOnChangesFeature],
+        features: [NgOnChangesFeature()],
         inputs: {name: 'name'}
       });
     }
@@ -1678,7 +1678,7 @@ describe('ViewContainerRef', () => {
             }
           },
           directives: [ComponentWithHooks, DirectiveWithVCRef],
-          features: [NgOnChangesFeature],
+          features: [NgOnChangesFeature()],
         });
       }
 
@@ -1771,7 +1771,7 @@ describe('ViewContainerRef', () => {
             }
           },
           directives: [ComponentWithHooks, DirectiveWithVCRef],
-          features: [NgOnChangesFeature],
+          features: [NgOnChangesFeature()],
         });
       }