fix(ivy): NgOnChangesFeature no longer included in hello_world (#28187)

- Wraps the NgOnChangesFeature in a factory such that no side effects occur in the module root
- Adds comments to ngInherit property on feature definition interface to help guide others not to make the same mistake
- Updates compiler to generate the feature properly after the change to it being a factory
- Updates appropriate tests

PR Close #28187
This commit is contained in:
Ben Lesh
2019-01-22 11:17:13 -08:00
committed by Alex Rickabaugh
parent a95e81978b
commit 5430d2bc66
13 changed files with 41 additions and 89 deletions

View File

@ -2008,7 +2008,7 @@ describe('lifecycles', () => {
vars: vars,
inputs: {a: 'val1', b: ['publicVal2', 'val2']}, template,
directives: directives,
features: [NgOnChangesFeature],
features: [NgOnChangesFeature()],
});
};
}
@ -2027,7 +2027,7 @@ describe('lifecycles', () => {
selectors: [['', 'dir', '']],
factory: () => new Directive(),
inputs: {a: 'val1', b: ['publicVal2', 'val2']},
features: [NgOnChangesFeature],
features: [NgOnChangesFeature()],
});
}
@ -2732,7 +2732,7 @@ describe('lifecycles', () => {
vars: vars,
inputs: {val: 'val'}, template,
directives: directives,
features: [NgOnChangesFeature],
features: [NgOnChangesFeature()],
});
};
}