cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: no longer run tslint from within gulp task (#35800)

Browse Source 
Switches our tslint setup to the standard `tslint.json` linter excludes.
The set of files that need to be linted is specified through a Yarn script.

For IDEs, open files are linted with the closest tslint configuration, if the
tslint IDE extension is set up, and the source file is not excluded.

We cannot use the language service plugin for tslint as we have multiple nested
tsconfig files, and we don't want to add the plugin to each tsconfig. We
could reduce that bloat by just extending from a top-level tsconfig that
defines the language service plugin, but unfortunately the tslint plugin does
not allow the use of tslint configs which are not part of the tsconfig project.

This is problematic since the tslint configuration is at the project root, and we
don't want to copy tslint configurations next to each tsconfig file.

Additionally, linting of `d.ts` files has been re-enabled. This has been
disabled in the past and a TODO has been left. This commit fixes the
lint issues and re-enables linting.

PR Close #35800
This commit is contained in:
Paul Gschwendtner
2020-03-02 18:35:30 +01:00
committed by atscott
parent 5349e46b46
commit 5615928df9
28 changed files with 171 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/ci/payload-size.js
View File

@ -1,3 +1,11 @@
/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
'use strict';
// Imports
@ -27,7 +35,7 @@ for (const compressionType in limitSizes) {
failed = true;
// An expected compression type/file combination is missing. Maybe the file was renamed or
// removed. Report it as an error, so the user updates the corresponding limit file.
console.log(
console.error(
`ERROR: Commit ${commit} ${compressionType} ${filename} measurement is missing. ` +
'Maybe the file was renamed or removed.');
} else {
@ -54,11 +62,11 @@ for (const compressionType in limitSizes) {
}
// Group failure messages separately from success messages so they are easier to find.
successMessages.concat(failureMessages).forEach(message => console.log(message));
successMessages.concat(failureMessages).forEach(message => console.error(message));
if (failed) {
console.log(`If this is a desired change, please update the size limits in file '${limitFile}'.`);
console.info(`If this is a desired change, please update the size limits in file '${limitFile}'.`);
process.exit(1);
} else {
console.log(`Payload size check passed. All diffs are less than 1% or 500 bytes.`);
console.info(`Payload size check passed. All diffs are less than 1% or 500 bytes.`);
}