From 561d402c652bf4ca51da9c7559d044b72f1c6295 Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Thu, 13 Feb 2020 19:02:04 -0800 Subject: [PATCH] build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-schematics (#33927) This means we don't need the action_env. Borrowed from @gkalpak's changes in https://github.com/angular/angular/pull/35381. PR Close #33927 --- .bazelrc | 7 ------- integration/BUILD.bazel | 5 ----- 2 files changed, 12 deletions(-) diff --git a/.bazelrc b/.bazelrc index d725d60450..17d4420bb9 100644 --- a/.bazelrc +++ b/.bazelrc @@ -72,13 +72,6 @@ test --test_output=errors build --deleted_packages=integration/bazel,integration/bazel/src,integration/bazel/src/hello-world,integration/bazel/test,integration/bazel/test/e2e query --deleted_packages=integration/bazel,integration/bazel/src,integration/bazel/src/hello-world,integration/bazel/test,integration/bazel/test/e2e -# The following environment variables need to be available for certain -# integration tests such as //integration:cli_hello_world_test - -# integration/bazel-schematics uses $CI_CHROMEDRIVER_VERSION_ARG in its postinstall webdriver-manager update -run --action_env=CI_CHROMEDRIVER_VERSION_ARG -test --action_env=CI_CHROMEDRIVER_VERSION_ARG - ################################ # Temporary Settings for Ivy # ################################ diff --git a/integration/BUILD.bazel b/integration/BUILD.bazel index 6be5a1cf1a..8f119b4fda 100644 --- a/integration/BUILD.bazel +++ b/integration/BUILD.bazel @@ -187,11 +187,6 @@ angular_integration_test( angular_integration_test( name = "bazel-schematics_test", - # integration/bazel-schematics uses $CI_CHROMEDRIVER_VERSION_ARG in its postinstall webdriver-manager update - # TODO(gregmagolan): remove that dependency have that test use puppeteer as well - configuration_env_vars = [ - "CI_CHROMEDRIVER_VERSION_ARG", - ], tags = [ "exclusive", "manual",