cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): fix issues found producing "Hello, World" example (#21790)

Browse Source 
PR Close #21790
This commit is contained in:
Chuck Jazdzewski
2018-01-25 15:38:39 -08:00
committed by Misko Hevery
parent 87754ad5ec
commit 5778bb820a
3 changed files with 68 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/compiler/src/constant_pool.ts
View File

@ -27,7 +27,7 @@ class FixupExpression extends o.Expression {
shared: boolean;
visitExpression(visitor: o.ExpressionVisitor, context: any): any {
this.resolved.visitExpression(visitor, context);
return this.resolved.visitExpression(visitor, context);
}
isEquivalent(e: o.Expression): boolean {

6
packages/compiler/src/render3/r3_view_compiler.ts
View File

@ -140,7 +140,7 @@ function unsupported(feature: string): never {
if (this) {
throw new Error(`Builder ${this.constructor.name} doesn't support ${feature} yet`);
}
throw new Error(`Feature ${feature} is supported yet`);
throw new Error(`Feature ${feature} is not supported yet`);
}
const BINDING_INSTRUCTION_MAP: {[index: number]: o.ExternalReference | undefined} = {
@ -571,7 +571,9 @@ function createFactory(
} else if (tokenRef === viewContainerRef) {
args.push(o.importExpr(R3.injectViewContainerRef).callFn([]));
} else {
args.push(o.importExpr(R3.inject).callFn([outputCtx.importExpr(token)]));
const value =
token.identifier != null ? outputCtx.importExpr(tokenRef) : o.literal(tokenRef);
args.push(o.importExpr(R3.inject).callFn([value]));
}
} else {
unsupported('dependency without a token');