cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(facade): remove useless facades

Browse Source
This commit is contained in:
Victor Berchet
2016-09-18 15:39:26 -07:00
committed by Rado Kirov
parent 34b31dea7c
commit 58605cf350
24 changed files with 91 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/@angular/platform-browser/src/dom/events/key_events.ts
View File

@ -39,11 +39,10 @@ export class KeyEventsPlugin extends EventManagerPlugin {
var parsedEvent = KeyEventsPlugin.parseEventName(eventName);
var outsideHandler = KeyEventsPlugin.eventCallback(
element, StringMapWrapper.get(parsedEvent, 'fullKey'), handler, this.manager.getZone());
element, parsedEvent['fullKey'], handler, this.manager.getZone());
return this.manager.getZone().runOutsideAngular(() => {
return getDOM().onAndCancel(
element, StringMapWrapper.get(parsedEvent, 'domEventName'), outsideHandler);
return getDOM().onAndCancel(element, parsedEvent['domEventName'], outsideHandler);
});
}
@ -72,9 +71,10 @@ export class KeyEventsPlugin extends EventManagerPlugin {
// returning null instead of throwing to let another plugin process the event
return null;
}
var result = {};
StringMapWrapper.set(result, 'domEventName', domEventName);
StringMapWrapper.set(result, 'fullKey', fullKey);
var result: {[k: string]: string} = {};
result['domEventName'] = domEventName;
result['fullKey'] = fullKey;
return result;
}
@ -89,7 +89,7 @@ export class KeyEventsPlugin extends EventManagerPlugin {
}
modifierKeys.forEach(modifierName => {
if (modifierName != key) {
var modifierGetter = StringMapWrapper.get(modifierKeyGetters, modifierName);
var modifierGetter = modifierKeyGetters[modifierName];
if (modifierGetter(event)) {
fullKey += modifierName + '.';
}

22
modules/@angular/platform-browser/test/browser_util_spec.ts
View File

@ -224,17 +224,17 @@ export function main() {
];
browsers.forEach((browser: {[key: string]: any}) => {
it(`should detect ${StringMapWrapper.get(browser, 'name')}`, () => {
var bd = new BrowserDetection(<string>StringMapWrapper.get(browser, 'ua'));
expect(bd.isFirefox).toBe(StringMapWrapper.get(browser, 'isFirefox'));
expect(bd.isAndroid).toBe(StringMapWrapper.get(browser, 'isAndroid'));
expect(bd.isEdge).toBe(StringMapWrapper.get(browser, 'isEdge'));
expect(bd.isIE).toBe(StringMapWrapper.get(browser, 'isIE'));
expect(bd.isWebkit).toBe(StringMapWrapper.get(browser, 'isWebkit'));
expect(bd.isIOS7).toBe(StringMapWrapper.get(browser, 'isIOS7'));
expect(bd.isSlow).toBe(StringMapWrapper.get(browser, 'isSlow'));
expect(bd.isChromeDesktop).toBe(StringMapWrapper.get(browser, 'isChromeDesktop'));
expect(bd.isOldChrome).toBe(StringMapWrapper.get(browser, 'isOldChrome'));
it(`should detect ${browser[ 'name']}`, () => {
var bd = new BrowserDetection(<string>browser['ua']);
expect(bd.isFirefox).toBe(browser['isFirefox']);
expect(bd.isAndroid).toBe(browser['isAndroid']);
expect(bd.isEdge).toBe(browser['isEdge']);
expect(bd.isIE).toBe(browser['isIE']);
expect(bd.isWebkit).toBe(browser['isWebkit']);
expect(bd.isIOS7).toBe(browser['isIOS7']);
expect(bd.isSlow).toBe(browser['isSlow']);
expect(bd.isChromeDesktop).toBe(browser['isChromeDesktop']);
expect(bd.isOldChrome).toBe(browser['isOldChrome']);
});
});
});