cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): remove superfluous bind() function (#32489)

Browse Source 
Historically bind() used to be a separate instruction. With a series of
refactoring it became a utility function but after recent code changes
it does not provide any valuable abstraction / help. On the contrary -
it can be seen as a performance problem (forces unnecessary comparison to
`NO_CHANGE` during change detection).

PR Close #32489
This commit is contained in:
Pawel Kozlowski
2019-09-05 11:16:56 +02:00
committed by Matias Niemelä
parent fed6b25be0
commit 5ab7cb4188
5 changed files with 22 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/render3/interfaces/i18n.ts
View File

@ -200,10 +200,10 @@ export const enum I18nUpdateOpCode {
* Assume
* ```ts
* if (rf & RenderFlags.Update) {
* i18nExp(bind(ctx.exp1)); // If changed set mask bit 1
* i18nExp(bind(ctx.exp2)); // If changed set mask bit 2
* i18nExp(bind(ctx.exp3)); // If changed set mask bit 3
* i18nExp(bind(ctx.exp4)); // If changed set mask bit 4
* i18nExp(ctx.exp1); // If changed set mask bit 1
* i18nExp(ctx.exp2); // If changed set mask bit 2
* i18nExp(ctx.exp3); // If changed set mask bit 3
* i18nExp(ctx.exp4); // If changed set mask bit 4
* i18nApply(0); // Apply all changes by executing the OpCodes.
* }
* ```