cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(dart/transform): Move BindGenerator tests to their own dir.

Browse Source 
Move existing BindGenerator test to its own directory and to test that
phase specificially, rather than the whole pipeline.
Add another BindGenerator test.
This commit is contained in:
Tim Blasi
2015-03-12 14:10:26 -07:00
parent 4b12c19560
commit 5c1c534894
12 changed files with 123 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/angular2/src/transform/bind_generator/generator.dart
View File

@ -27,7 +27,7 @@ List<String> _generateSetters(Map<String, String> bindMap) {
var setters = [];
// TODO(kegluneq): Include types for receivers. See #886.
bindMap.forEach((prop, type) {
setters.add('\'$prop\': (o, String v) => o.$prop = v');
setters.add(''''$prop': (o, String v) => o.$prop = v''');
});
return setters;
}

10
modules/angular2/src/transform/common/registered_type.dart
View File

@ -10,13 +10,13 @@ class RegisteredType {
/// The actual call to `Reflector#registerType`.
final MethodInvocation registerMethod;
/// The factory method registered.
final Expression factory;
final Expression factoryFn;
/// The parameters registered.
final Expression parameters;
/// The annotations registered.
final Expression annotations;
RegisteredType._(this.typeName, this.registerMethod, this.factory,
RegisteredType._(this.typeName, this.registerMethod, this.factoryFn,
this.parameters, this.annotations);
/// Creates a [RegisteredType] given a [MethodInvocation] node representing
@ -25,14 +25,14 @@ class RegisteredType {
var visitor = new _ParseRegisterTypeVisitor();
registerMethod.accept(visitor);
return new RegisteredType._(visitor.typeName, registerMethod,
visitor.factory, visitor.parameters, visitor.annotations);
visitor.factoryFn, visitor.parameters, visitor.annotations);
}
}
class _ParseRegisterTypeVisitor extends Object
with RecursiveAstVisitor<Object> {
Identifier typeName;
Expression factory;
Expression factoryFn;
Expression parameters;
Expression annotations;
@ -56,7 +56,7 @@ class _ParseRegisterTypeVisitor extends Object
annotations = node.value;
break;
case 'factory':
factory = node.value;
factoryFn = node.value;
break;
case 'parameters':
parameters = node.value;

8
modules/angular2/src/transform/directive_processor/rewriter.dart
View File

@ -64,7 +64,7 @@ class CreateNgDepsVisitor extends Object
}
void _writeImport() {
writer.print('import \'${path.basename(importPath)}\';');
writer.print('''import '${path.basename(importPath)}';''');
}
@override
@ -150,19 +150,19 @@ class CreateNgDepsVisitor extends Object
}
writer.print('..registerType(');
visitNode(node.name);
writer.print(', {\'factory\': ');
writer.print(''', {'factory': ''');
if (ctor == null) {
_generateEmptyFactory(node.name.toString());
} else {
ctor.accept(_factoryVisitor);
}
writer.print(', \'parameters\': ');
writer.print(''', 'parameters': ''');
if (ctor == null) {
_generateEmptyParams();
} else {
ctor.accept(_paramsVisitor);
}
writer.print(', \'annotations\': ');
writer.print(''', 'annotations': ''');
node.accept(_metaVisitor);
writer.print('})');