cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(animations): ensure animations are disabled on the element containing the @.disabled flag (#18714)

Browse Source 
Prior to fix this fix, @.disabled would only work to disable child
animations. Now it will also disable animations for the element that has
the @.disabled flag (which makes more sense).

PR Close #18714
This commit is contained in:
Matias Niemelä
2017-08-15 13:43:14 -07:00
committed by Miško Hevery
parent ac58914b97
commit 5d68c830d2
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/test/animation/animation_integration_spec.ts
View File

@ -2349,7 +2349,7 @@ export function main() {
expect(players[0].totalTime).toEqual(1234);
});
it('should not disable animations for the element that they are disabled on', () => {
it('should disable animations for the element that they are disabled on', () => {
@Component({
selector: 'if-cmp',
template: `
@ -2384,8 +2384,7 @@ export function main() {
fixture.detectChanges();
let players = getLog();
expect(players.length).toEqual(1);
expect(players[0].totalTime).toEqual(1234);
expect(players.length).toEqual(0);
resetLog();
cmp.disableExp = false;