cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): take styles extracted from template into account in JIT mode (#34017)

Browse Source 
Prior to this commit, all styles extracted from Component's template (defined using <style> tags) were ignored by JIT compiler, so only `styles` array values defined in @Component decorator were used. This change updates JIT compiler to take styles extracted from the template into account. It also ensures correct order where `styles` array values are applied first and template styles are applied second.

PR Close #34017
This commit is contained in:
Andrew Kushnir
2019-11-23 15:36:00 -08:00
committed by Matias Niemelä
parent d655093123
commit 5de7960f01
3 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
View File

@ -5155,13 +5155,16 @@ export const Foo = Foo__PRE_R3__;
@Component({
selector: 'test',
template: '<style>h1 {font-size: larger}</style>',
styles: ['h2 {width: 10px}']
})
export class TestCmp {}
`);
env.driveMain();
const jsContents = env.getContents('test.js');
expect(jsContents).toContain('styles: ["h1[_ngcontent-%COMP%] {font-size: larger}"]');
expect(jsContents)
.toContain(
'styles: ["h2[_ngcontent-%COMP%] {width: 10px}", "h1[_ngcontent-%COMP%] {font-size: larger}"]');
});
it('should process inline <link> tags', () => {