From 5ed091e2608e0852edcafef083dd01e7d4fe5f3c Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Thu, 21 May 2015 23:33:49 -0700 Subject: [PATCH] build(gulp): fix test.unit.dart - format code for the first run - don't run tests if first build fails Closes #1647 --- gulpfile.js | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index e12ef1a528..8cc776ad44 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -418,12 +418,21 @@ gulp.task('!test.unit.js/karma-run', function(done) { }); -gulp.task('test.unit.dart', ['build/tree.dart'], function (done) { +gulp.task('test.unit.dart', function (done) { runSequence( + 'build/tree.dart', + 'build/format.dart', '!test.unit.dart/karma-server', '!test.unit.dart/karma-run', - function() { - watch('modules/angular2/**', [ + function(error) { + // if initial build failed (likely due to build or formatting step) then exit + // otherwise karma server doesn't start and we can't continue running properly + if (error) { + done(error); + return; + } + + watch('modules/angular2/**', { ignoreInitial: true, log: watchLog }, [ '!build/tree.dart', 'build/format.dart', '!test.unit.dart/karma-run'