From 5f08bdf8b999a9e41246ade208114462e447a59e Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Mon, 6 Aug 2018 12:06:50 -0700 Subject: [PATCH] ci: github robot should enforce that all requested reviews are submitted (#25336) See docs in the diff for justification. PR Close #25336 --- .github/angular-robot.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/angular-robot.yml b/.github/angular-robot.yml index 471cba19d1..d807d258e1 100644 --- a/.github/angular-robot.yml +++ b/.github/angular-robot.yml @@ -62,6 +62,13 @@ merge: # list of checks that will determine if the merge label can be added checks: + + # require that the PR has reviews from all requested reviewers + # + # This enables us to request reviews from both eng and tech writers, or multiple eng folks, and prevents accidental merges. + # Rather than merging PRs with pending reviews, if all PullApprove requirements are satisfied and additional reviews are not needed pending reviewers should be removed via GitHub UI (this also leaves an audit trail behind these decisions). + requireReviews: true, + # whether the PR shouldn't have a conflict with the base branch noConflict: true # list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master")