build: update to nodejs rules 0.34.0 and bazel 0.28.1 (#31824)

nodejs rules 0.34.0 now includes protractor_web_test_suite rule (via new @bazel/protractor rule) so we switch to that location for that rule in this PR so that /packages/bazel/src/protractor can be removed in a future PR

this PR also brings in node toolchain support which was released in nodejs rules 0.33.0. this is a prerequisite for RBE for mac & windows users

bazel schematics also updated with the same. @bazel/bazel 0.28.1 npm package includes transitive dep on hide-bazel-files so we're able to remove an explicit dep on that as well.

PR Close #31824

packages/bazel/src/builders/files/WORKSPACE.template

@@ -15,8 +15,8 @@ workspace(
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-RULES_NODEJS_VERSION = "0.32.2"
-RULES_NODEJS_SHA256 = "6d4edbf28ff6720aedf5f97f9b9a7679401bf7fca9d14a0fff80f644a99992b4"
+RULES_NODEJS_VERSION = "0.34.0"
+RULES_NODEJS_SHA256 = "7c4a690268be97c96f04d505224ec4cb1ae53c2c2b68be495c9bd2634296a5cd"
 http_archive(
     name = "build_bazel_rules_nodejs",
     sha256 = RULES_NODEJS_SHA256,
@@ -63,8 +63,6 @@ node_repositories(
 
 yarn_install(
     name = "npm",
-    # TODO(gregmagolan): fix rules_nodejs so that if @bazel/hide-bazel-files is detected then this is forced true
-    always_hide_bazel_files = True,
     package_json = "//:package.json",
     yarn_lock = "//:yarn.lock",
 )
@@ -72,6 +70,9 @@ yarn_install(
 load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")
 install_bazel_dependencies()
 
+load("@npm_bazel_protractor//:package.bzl", "npm_bazel_protractor_dependencies")
+npm_bazel_protractor_dependencies()
+
 load("@npm_bazel_karma//:package.bzl", "rules_karma_dependencies")
 rules_karma_dependencies()
 

packages/bazel/src/builders/files/e2e/BUILD.bazel.template

@@ -1,5 +1,5 @@
+load("@npm_bazel_protractor//:index.bzl", "protractor_web_test_suite")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 
 ts_library(
     name = "e2e_lib",
@@ -21,10 +21,6 @@ ts_library(
 
 protractor_web_test_suite(
     name = "prodserver_test",
-    data = [
-      "@npm//@angular/bazel",
-      "@npm//protractor",
-    ],
     on_prepare = ":protractor.on-prepare.js",
     server = "//src:prodserver",
     deps = [":e2e_lib"],
@@ -32,10 +28,6 @@ protractor_web_test_suite(
 
 protractor_web_test_suite(
     name = "devserver_test",
-    data = [
-      "@npm//@angular/bazel",
-      "@npm//protractor",
-    ],
     on_prepare = ":protractor.on-prepare.js",
     server = "//src:devserver",
     deps = [":e2e_lib"],

packages/bazel/src/schematics/ng-add/files/e2e/protractor.on-prepare.js.template

@@ -5,11 +5,11 @@
 // If the function returns a promise, as it does here, protractor will wait
 // for the promise to resolve before running tests.
 
-const protractorUtils = require('@angular/bazel/protractor-utils');
+const protractorUtils = require('@bazel/protractor/protractor-utils');
 const protractor = require('protractor');
 
 module.exports = function(config) {
-  // In this example, `@angular/bazel/protractor-utils` is used to run
+  // In this example, `@bazel/protractor/protractor-utils` is used to run
   // the server. protractorUtils.runServer() runs the server on a randomly
   // selected port (given a port flag to pass to the server as an argument).
   // The port used is returned in serverSpec and the protractor serverUrl

packages/bazel/src/schematics/ng-add/index.ts

@@ -48,11 +48,11 @@ function addDevDependenciesToPackageJson(options: Schema) {
 
     const devDependencies: {[k: string]: string} = {
       '@angular/bazel': angularCoreVersion,
-      '@bazel/bazel': '^0.27.0',
-      '@bazel/hide-bazel-files': '0.32.2',
+      '@bazel/bazel': '^0.28.1',
       '@bazel/ibazel': '^0.10.2',
-      '@bazel/karma': '0.32.2',
-      '@bazel/typescript': '0.32.2',
+      '@bazel/karma': '0.34.0',
+      '@bazel/protractor': '0.34.0',
+      '@bazel/typescript': '0.34.0',
     };
 
     const recorder = host.beginUpdate(packageJson);

packages/bazel/src/schematics/ng-add/index_spec.ts

@@ -113,9 +113,10 @@ describe('ng-add schematic', () => {
     const json = JSON.parse(content);
     const devDeps = Object.keys(json.devDependencies);
     expect(devDeps).toContain('@bazel/bazel');
-    expect(devDeps).toContain('@bazel/hide-bazel-files');
     expect(devDeps).toContain('@bazel/ibazel');
     expect(devDeps).toContain('@bazel/karma');
+    expect(devDeps).toContain('@bazel/protractor');
+    expect(devDeps).toContain('@bazel/typescript');
   });
 
   it('should replace an existing dev dependency', async() => {