refactor(benchpress): added tsconfig to ts_library rules and awaited floating promises (#35147)

* Note: we specify our own tsconfig bc the default tsconfig we provide for ts_library disables the must-use-promises rule

PR Close #35147
This commit is contained in:
Wagner Maciel
2020-02-05 09:39:29 -08:00
committed by Kara Erickson
parent 5efe9be051
commit 60471c092f
12 changed files with 26 additions and 15 deletions

View File

@ -23,6 +23,7 @@ ts_library(
name = "perf_lib",
testonly = 1,
srcs = ["class_bindings.perf-spec.ts"],
tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
deps = [
"//modules/e2e_util",
"@npm//protractor",

View File

@ -13,7 +13,7 @@ describe('class bindings perf', () => {
it('should work for update', async() => {
browser.rootEl = '#root';
runBenchmark({
await runBenchmark({
id: 'create',
url: '',
ignoreBrowserSynchronization: true,
@ -25,7 +25,7 @@ describe('class bindings perf', () => {
it('should work for update', async() => {
browser.rootEl = '#root';
runBenchmark({
await runBenchmark({
id: 'update',
url: '',
ignoreBrowserSynchronization: true,