refactor(benchpress): added tsconfig to ts_library rules and awaited floating promises (#35147)

* Note: we specify our own tsconfig bc the default tsconfig we provide for ts_library disables the must-use-promises rule

PR Close #35147
This commit is contained in:
Wagner Maciel
2020-02-05 09:39:29 -08:00
committed by Kara Erickson
parent 5efe9be051
commit 60471c092f
12 changed files with 26 additions and 15 deletions

View File

@ -5,6 +5,7 @@ package(default_visibility = ["//visibility:public"])
ts_library(
name = "util_lib",
srcs = ["util.ts"],
tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
deps = ["//modules/benchmarks/src:util_lib"],
)
@ -12,6 +13,7 @@ ts_library(
name = "perf_tests_lib",
testonly = 1,
srcs = ["largetable.perf-spec.ts"],
tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
deps = [
"//modules/e2e_util",
"@npm//protractor",

View File

@ -49,7 +49,7 @@ describe('largetable benchmark perf', () => {
[CreateOnlyWorker, CreateAndDestroyWorker, UpdateWorker].forEach((worker) => {
describe(worker.id, () => {
it(`should run benchmark for ${testPackageName}`, async() => {
runTableBenchmark({
await runTableBenchmark({
id: `largeTable.${testPackageName}.${worker.id}`,
url: '/',
ignoreBrowserSynchronization: true,