From 61cd5f7c0f0812a45afd7c5501c8e49e17b0455f Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Mon, 13 Aug 2018 07:23:45 +0100 Subject: [PATCH] build(docs-infra): fix individual API overload templates (#24976) * Make individual overloads collapsible * Show only the first overload expanded, rest collapsed * Text changes to 'collapse all' once 'show all' is clicked * Fix chevron/carrot rotation animation when overloads / overload item is expanded or collapsed PR Close #24976 --- aio/src/styles/1-layouts/_api-pages.scss | 34 ++++++++++++++++--- .../templates/api/lib/memberHelpers.html | 19 +++++++---- 2 files changed, 43 insertions(+), 10 deletions(-) diff --git a/aio/src/styles/1-layouts/_api-pages.scss b/aio/src/styles/1-layouts/_api-pages.scss index a2d7809585..8088a71aeb 100644 --- a/aio/src/styles/1-layouts/_api-pages.scss +++ b/aio/src/styles/1-layouts/_api-pages.scss @@ -161,13 +161,35 @@ summary { height: inherit; - padding: 0 8px 8px; + padding: 0 0 8px; h4 { margin: 0; } + + .show-all { + display: initial; + } + .collapse-all { + display: none; + } } - } + + &[open] > summary { + .show-all { + display: none; + } + .collapse-all { + display: initial; + } + } + } + + details.overload { + box-shadow: none; + margin: 0; + } + .from-constructor, .read-only-property { font-size: 12px; @@ -248,7 +270,11 @@ details { padding: 16px 24px; } - &[open] > i.material-icons { - @include rotate(180deg); // Rotate the icon + // Rotate the icon + summary i.material-icons.expand { + @include rotate(0deg); + } + &[open] > summary i.material-icons.expand { + @include rotate(180deg); } } diff --git a/aio/tools/transforms/templates/api/lib/memberHelpers.html b/aio/tools/transforms/templates/api/lib/memberHelpers.html index c4d991528f..0a15539262 100644 --- a/aio/tools/transforms/templates/api/lib/memberHelpers.html +++ b/aio/tools/transforms/templates/api/lib/memberHelpers.html @@ -124,7 +124,11 @@
@@ -133,14 +137,17 @@
{% endif %} {% for overload in method.overloads %} -
-
- Overload #{$ loop.index $} of {$ method.overloads.length $} - expand_more
+
+ +
+
Overload #{$ loop.index $} of {$ method.overloads.length $}
+ expand_more +
+
{$ renderOverloadInfo(overload, cssClass + '-overload', method) $} {% if not loop.last %}
{% endif %} +
{% endfor %} -