cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): unable to bind to properties that start with class or style (#32421)

Browse Source 
Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes #32310

PR Close #32421
This commit is contained in:
crisbeto
2019-08-30 20:19:39 +02:00
committed by Matias Niemelä
parent 098feec4a0
commit 62d92f8091
2 changed files with 47 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/compiler/src/render3/view/styling_builder.ts
View File

@ -149,9 +149,10 @@ export class StylingBuilder {
registerInputBasedOnName(name: string, expression: AST, sourceSpan: ParseSourceSpan) {
let binding: BoundStylingEntry|null = null;
const nameToMatch = name.substring(0, 5); // class | style
const isStyle = nameToMatch === 'style';
const isClass = isStyle ? false : (nameToMatch === 'class');
const prefix = name.substring(0, 6);
const isStyle = name === 'style' || prefix === 'style.' || prefix === 'style!';
const isClass = !isStyle &&
(name === 'class' || name === 'className' || prefix === 'class.' || prefix === 'class!');
if (isStyle || isClass) {
const isMapBased = name.charAt(5) !== '.'; // style.prop or class.prop makes this a no
const property = name.substr(isMapBased ? 5 : 6); // the dot explains why there's a +1