cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): avoid generating instructions for empty style and class bindings (#30024)

Browse Source 
Fixes Ivy throwing an error because it tries to generate styling instructions for empty `style` and `class` bindings.

This PR resolves FW-1274.

PR Close #30024
This commit is contained in:
Kristiyan Kostadinov
2019-04-22 10:28:59 +02:00
committed by Ben Lesh
parent a9242c4fc2
commit 63523f7964
4 changed files with 82 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
packages/compiler-cli/test/compliance/r3_view_compiler_styling_spec.ts
View File

@ -649,6 +649,30 @@ describe('compiler compliance: styling', () => {
expectEmit(result.source, template, 'Incorrect template');
});
it('should not create instructions for empty style bindings', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';
@Component({
selector: 'my-component',
template: \`<div [style.color]></div>\`
})
export class MyComponent {
}
@NgModule({declarations: [MyComponent]})
export class MyModule {}
`
}
};
const result = compile(files, angularFiles);
expect(result.source).not.toContain('elementStyling');
});
});
describe('[class]', () => {
@ -802,6 +826,30 @@ describe('compiler compliance: styling', () => {
const result = compile(files, angularFiles);
expectEmit(result.source, template, 'Incorrect template');
});
it('should not create instructions for empty class bindings', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';
@Component({
selector: 'my-component',
template: \`<div [class.is-open]></div>\`
})
export class MyComponent {
}
@NgModule({declarations: [MyComponent]})
export class MyModule {}
`
}
};
const result = compile(files, angularFiles);
expect(result.source).not.toContain('elementStyling');
});
});
describe('[style] mixed with [class]', () => {