cargdev/angular
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: ensure all 'TODO's are consistent (#23252)

Browse Source 
PR Close #23252
This commit is contained in:
Rafael
2018-04-08 18:19:25 -03:00
committed by Igor Minar
parent aa27155618
commit 639d52fe71
26 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/benchpress/src/runner.ts
View File

@ -73,7 +73,7 @@ export class Runner {
// This might still create instances twice. We are creating a new injector with all the
// providers.
// Only WebDriverAdapter is reused.
// TODO vsavkin consider changing it when toAsyncFactory is added back or when child
// TODO(vsavkin): consider changing it when toAsyncFactory is added back or when child
// injectors are handled better.
const injector = Injector.create([
sampleProviders, {provide: Options.CAPABILITIES, useValue: capabilities},

26
packages/core/src/change_detection/differs/default_iterable_differ.ts
View File

@ -248,7 +248,7 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
this._removalsHead = this._removalsTail = null;
this._identityChangesHead = this._identityChangesTail = null;
// todo(vicb) when assert gets supported
// TODO(vicb): when assert gets supported
// assert(!this.isDirty);
}
}
@ -420,11 +420,11 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
this._insertAfter(record, prevRecord, index);
if (this._additionsTail === null) {
// todo(vicb)
// TODO(vicb):
// assert(this._additionsHead === null);
this._additionsTail = this._additionsHead = record;
} else {
// todo(vicb)
// TODO(vicb):
// assert(_additionsTail._nextAdded === null);
// assert(record._nextAdded === null);
this._additionsTail = this._additionsTail._nextAdded = record;
@ -436,14 +436,14 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
_insertAfter(
record: IterableChangeRecord_<V>, prevRecord: IterableChangeRecord_<V>|null,
index: number): IterableChangeRecord_<V> {
// todo(vicb)
// TODO(vicb):
// assert(record != prevRecord);
// assert(record._next === null);
// assert(record._prev === null);
const next: IterableChangeRecord_<V>|null =
prevRecord === null ? this._itHead : prevRecord._next;
// todo(vicb)
// TODO(vicb):
// assert(next != record);
// assert(prevRecord != record);
record._next = next;
@ -482,7 +482,7 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
const prev = record._prev;
const next = record._next;
// todo(vicb)
// TODO(vicb):
// assert((record._prev = null) === null);
// assert((record._next = null) === null);
@ -502,7 +502,7 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
/** @internal */
_addToMoves(record: IterableChangeRecord_<V>, toIndex: number): IterableChangeRecord_<V> {
// todo(vicb)
// TODO(vicb):
// assert(record._nextMoved === null);
if (record.previousIndex === toIndex) {
@ -510,11 +510,11 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
}
if (this._movesTail === null) {
// todo(vicb)
// TODO(vicb):
// assert(_movesHead === null);
this._movesTail = this._movesHead = record;
} else {
// todo(vicb)
// TODO(vicb):
// assert(_movesTail._nextMoved === null);
this._movesTail = this._movesTail._nextMoved = record;
}
@ -531,12 +531,12 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
record._nextRemoved = null;
if (this._removalsTail === null) {
// todo(vicb)
// TODO(vicb):
// assert(_removalsHead === null);
this._removalsTail = this._removalsHead = record;
record._prevRemoved = null;
} else {
// todo(vicb)
// TODO(vicb):
// assert(_removalsTail._nextRemoved === null);
// assert(record._nextRemoved === null);
record._prevRemoved = this._removalsTail;
@ -607,7 +607,7 @@ class _DuplicateItemRecordList<V> {
record._nextDup = null;
record._prevDup = null;
} else {
// todo(vicb)
// TODO(vicb):
// assert(record.item == _head.item ||
// record.item is num && record.item.isNaN && _head.item is num && _head.item.isNaN);
this._tail !._nextDup = record;
@ -636,7 +636,7 @@ class _DuplicateItemRecordList<V> {
* Returns whether the list of duplicates is empty.
*/
remove(record: IterableChangeRecord_<V>): boolean {
// todo(vicb)
// TODO(vicb):
// assert(() {
// // verify that the record being removed is in the list.
// for (IterableChangeRecord_ cursor = _head; cursor != null; cursor = cursor._nextDup) {

2
packages/core/src/util/lang.ts
View File

@ -21,6 +21,6 @@ export function isPromise(obj: any): obj is Promise<any> {
* Determine if the argument is an Observable
*/
export function isObservable(obj: any | Observable<any>): obj is Observable<any> {
// TODO use Symbol.observable when https://github.com/ReactiveX/rxjs/issues/2415 will be resolved
// TODO: use Symbol.observable when https://github.com/ReactiveX/rxjs/issues/2415 will be resolved
return !!obj && typeof obj.subscribe === 'function';
}

2
packages/core/test/change_detection/differs/default_iterable_differ_spec.ts
View File

@ -23,7 +23,7 @@ class ComplexItem {
toString() { return `{id: ${this.id}, color: ${this.color}}`; }
}
// todo(vicb): UnmodifiableListView / frozen object when implemented
// TODO(vicb): UnmodifiableListView / frozen object when implemented
{
describe('iterable differ', function() {
describe('DefaultIterableDiffer', function() {

2
packages/core/test/change_detection/differs/default_keyvalue_differ_spec.ts
View File

@ -11,7 +11,7 @@ import {DefaultKeyValueDiffer, DefaultKeyValueDifferFactory} from '@angular/core
import {kvChangesAsString, testChangesAsString} from '../../change_detection/util';
// todo(vicb): Update the code & tests for object equality
// TODO(vicb): Update the code & tests for object equality
{
describe('keyvalue differ', function() {
describe('DefaultKeyValueDiffer', function() {

2
packages/http/testing/src/mock_backend.ts
View File

@ -19,7 +19,7 @@ import {take} from 'rxjs/operators';
* @deprecated use @angular/common/http instead
*/
export class MockConnection implements Connection {
// TODO Name `readyState` should change to be more generic, and states could be made to be more
// TODO: Name `readyState` should change to be more generic, and states could be made to be more
// descriptive than ResourceLoader states.
/**
* Describes the state of the connection, based on `XMLHttpRequest.readyState`, but with

2
packages/platform-webworker/src/web_workers/shared/post_message_bus.ts
View File

@ -12,7 +12,7 @@ import {MessageBus, MessageBusSink, MessageBusSource} from './message_bus';
// TODO(jteplitz602) Replace this with the definition in lib.webworker.d.ts(#3492)
// TODO(jteplitz602): Replace this with the definition in lib.webworker.d.ts(#3492)
export interface PostMessageTarget {
postMessage: (message: any, transfer?: [ArrayBuffer]) => void;
}

2
packages/platform-webworker/src/worker_app.ts
View File

@ -33,7 +33,7 @@ export function errorHandler(): ErrorHandler {
}
// TODO(jteplitz602) remove this and compile with lib.webworker.d.ts (#3492)
// TODO(jteplitz602): remove this and compile with lib.webworker.d.ts (#3492)
const _postMessage = {
postMessage: (message: any, transferrables?: [ArrayBuffer]) => {
(<any>postMessage)(message, transferrables);