cargdev/angular
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(build): enable type-checking for TypeScript ES6 emit.

Browse Source 
This requires delicate handling of type definitions which collide, because
we use TypeScript-provided lib.d.ts for --target=es5 and lib.es6.d.ts for
--target=es6.
We need to include our polyfill typings only in the --target=es5 case,
and the usages have to be consistent with lib.es6.d.ts.
Also starting with this change we now typecheck additional modules,
so this fixes a bunch of wrong typings which were never checked before.

Fixes #3178
This commit is contained in:
Alex Eagle
2015-08-06 09:52:33 -07:00
parent 40a3cd2ab1
commit 643c71740e
35 changed files with 88 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/benchpress/index.ts
View File

@ -3,4 +3,4 @@ require('traceur/bin/traceur-runtime');
module.exports = require('./benchpress.js');
// when bundling benchpress to one file, this is used
// for getting exports out of browserify's scope.
global.__benchpressExports = module.exports;
(<any>global).__benchpressExports = module.exports;

8
modules/benchpress/src/webdriver/selenium_webdriver_adapter.ts
View File

@ -2,7 +2,7 @@ import {Promise, PromiseWrapper} from 'angular2/src/facade/async';
import {bind, Binding} from 'angular2/di';
import {WebDriverAdapter} from '../web_driver_adapter';
import webdriver = require('selenium-webdriver');
import * as webdriver from 'selenium-webdriver';
/**
* Adapter for the selenium-webdriver.
@ -56,5 +56,7 @@ function convertToLocalProcess(data): Object {
return JSON.parse(serialized);
}
var _PROTRACTOR_BINDINGS =
[bind(WebDriverAdapter).toFactory(() => new SeleniumWebDriverAdapter(global.browser), [])];
var _PROTRACTOR_BINDINGS = [
bind(WebDriverAdapter)
.toFactory(() => new SeleniumWebDriverAdapter((<any>global).browser), [])
];