cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

perf: don't create holey arrays (#32155)

Browse Source 
Don't use `Array` constructor with the size value (ex. `new Array(5)`) - this will create a `HOLEY_ELEMENTS` array (even if this array is filled in later on!);

https://v8.dev/blog/elements-kinds
https://stackoverflow.com/questions/32054170/how-to-resize-an-array

PR Close #32155
This commit is contained in:
Miško Hevery
2019-08-15 13:42:17 -07:00
committed by Andrew Kushnir
parent c957dfc167
commit 64770571b2
32 changed files with 137 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/compiler/src/i18n/digest.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {utf8Encode} from '../util';
import {newArray, utf8Encode} from '../util';
import * as i18n from './i18n_ast';
@ -93,7 +93,7 @@ export function sha1(str: string): string {
const words32 = stringToWords32(utf8, Endian.Big);
const len = utf8.length * 8;
const w = new Array(80);
const w = newArray(80);
let [a, b, c, d, e]: number[] = [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476, 0xc3d2e1f0];
words32[len >> 5] |= 0x80 << (24 - len % 32);
@ -247,9 +247,10 @@ function rol64([hi, lo]: [number, number], count: number): [number, number] {
}
function stringToWords32(str: string, endian: Endian): number[] {
const words32 = Array((str.length + 3) >>> 2);
const size = (str.length + 3) >>> 2;
const words32 = [];
for (let i = 0; i < words32.length; i++) {
for (let i = 0; i < size; i++) {
words32[i] = wordAt(str, i * 4, endian);
}