cargdev/angular
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): renamed previousOrParent to currentTNode (#38707)

Browse Source 
The previous name of `previousOrParent` was confusing. Changed the
terminology to `currentTNode`.

PR Close #38707
This commit is contained in:
Misko Hevery
2020-09-14 13:43:44 -07:00
parent 0fa208f624
commit 65d4e7a8af
26 changed files with 161 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/test/render3/i18n_debug_spec.ts
View File

@ -128,7 +128,7 @@ describe('i18n debug', () => {
it('should print ElementEnd', () => {
expect(i18nMutateOpCodesToString([
1 << I18nMutateOpCode.SHIFT_REF | I18nMutateOpCode.ElementEnd,
])).toEqual(['setPreviousOrParentTNode(tView.data[1] as TNode)']);
])).toEqual(['setCurrentTNode(tView.data[1] as TNode)']);
});
it('should print RemoveNestedIcu', () => {

10
packages/core/test/render3/i18n_spec.ts
View File

@ -112,13 +112,13 @@ describe('Runtime i18n', () => {
'(lView[1] as Element).appendChild(lView[2])',
'lView[5] = document.createTextNode("world")',
'(lView[2] as Element).appendChild(lView[5])',
'setPreviousOrParentTNode(tView.data[2] as TNode)',
'setCurrentTNode(tView.data[2] as TNode)',
'lView[6] = document.createTextNode(" and ")',
'(lView[1] as Element).appendChild(lView[6])',
'(lView[1] as Element).appendChild(lView[3])',
'lView[7] = document.createTextNode("universe")',
'(lView[3] as Element).appendChild(lView[7])',
'setPreviousOrParentTNode(tView.data[3] as TNode)',
'setCurrentTNode(tView.data[3] as TNode)',
'lView[8] = document.createTextNode("!")',
'(lView[1] as Element).appendChild(lView[8])',
]),
@ -221,8 +221,7 @@ describe('Runtime i18n', () => {
'(lView[1] as Element).appendChild(lView[3])',
'(lView[1] as Element).appendChild(lView[16381])',
'lView[4] = document.createTextNode("after")',
'(lView[1] as Element).appendChild(lView[4])',
'setPreviousOrParentTNode(tView.data[1] as TNode)'
'(lView[1] as Element).appendChild(lView[4])', 'setCurrentTNode(tView.data[1] as TNode)'
]),
update: [],
icus: null
@ -242,8 +241,7 @@ describe('Runtime i18n', () => {
create: debugMatch([
'(lView[0] as Element).appendChild(lView[1])',
'lView[2] = document.createTextNode("middle")',
'(lView[1] as Element).appendChild(lView[2])',
'setPreviousOrParentTNode(tView.data[1] as TNode)'
'(lView[1] as Element).appendChild(lView[2])', 'setCurrentTNode(tView.data[1] as TNode)'
]),
update: [],
icus: null

2
packages/core/test/render3/render_util.ts
View File

@ -236,7 +236,7 @@ export function resetDOM() {
containerEl.setAttribute('host', '');
document.body.appendChild(containerEl);
hostView = null;
// TODO: assert that the global state is clean (e.g. ngData, previousOrParentNode, etc)
// TODO: assert that the global state is clean (e.g. ngData, currentTNode, etc)
}