cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): do not generate providedIn: null (#34116)

Browse Source 
We should only generate the `providedIn` property in injectable
defs if it has a non-null value. `null` does not communicate
any information to the runtime that isn't communicated already
by the absence of the property.

This should give us some modest code size savings.

PR Close #34116
This commit is contained in:
Kara Erickson
2019-11-27 16:25:47 -08:00
committed by Miško Hevery
parent 56f4e56094
commit 67eac733d2
4 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/compiler-cli/test/compliance/r3_view_compiler_di_spec.ts
View File

@ -90,8 +90,7 @@ describe('compiler compliance: dependency injection', () => {
const def = `
MyService.ɵprov = $r3$.ɵɵdefineInjectable({
token: MyService,
factory: MyService.ɵfac,
providedIn: null
factory: MyService.ɵfac
});
`;
@ -146,8 +145,7 @@ describe('compiler compliance: dependency injection', () => {
token: MyService,
factory: function() {
return alternateFactory();
},
providedIn: null
}
});
`;
@ -186,8 +184,7 @@ describe('compiler compliance: dependency injection', () => {
r = (() => new MyAlternateFactory())($r3$.ɵɵinject(SomeDep));
}
return r;
},
providedIn: null
}
});
`;
@ -219,8 +216,7 @@ describe('compiler compliance: dependency injection', () => {
token: MyService,
factory: function(t) {
return MyAlternateService.ɵfac(t);
},
providedIn: null
}
});
`;
@ -261,8 +257,7 @@ describe('compiler compliance: dependency injection', () => {
r = new MyAlternateService($r3$.ɵɵinject(SomeDep));
}
return r;
},
providedIn: null
}
});
`;
@ -344,14 +339,14 @@ describe('compiler compliance: dependency injection', () => {
const MyPipeDefs = `
MyPipe.ɵfac = function MyPipe_Factory(t) { return new (t || MyPipe)(i0.ɵɵdirectiveInject(Service)); };
MyPipe.ɵpipe = i0.ɵɵdefinePipe({ name: "myPipe", type: MyPipe, pure: true });
MyPipe.ɵprov = i0.ɵɵdefineInjectable({ token: MyPipe, factory: MyPipe.ɵfac, providedIn: null });
MyPipe.ɵprov = i0.ɵɵdefineInjectable({ token: MyPipe, factory: MyPipe.ɵfac });
`;
// The prov definition must be last so MyOtherPipe.fac is defined
const MyOtherPipeDefs = `
MyOtherPipe.ɵfac = function MyOtherPipe_Factory(t) { return new (t || MyOtherPipe)($r3$.ɵɵdirectiveInject(Service)); };
MyOtherPipe.ɵpipe = i0.ɵɵdefinePipe({ name: "myOtherPipe", type: MyOtherPipe, pure: true });
MyOtherPipe.ɵprov = i0.ɵɵdefineInjectable({ token: MyOtherPipe, factory: MyOtherPipe.ɵfac, providedIn: null });
MyOtherPipe.ɵprov = i0.ɵɵdefineInjectable({ token: MyOtherPipe, factory: MyOtherPipe.ɵfac });
`;
expectEmit(source, MyPipeDefs, 'Invalid pipe factory function');