cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Revert: "feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings" (#34616)

Browse Source 
This change reverts https://github.com/angular/angular/pull/28711
NOTE: This change deletes code and creates a BROKEN SHA. If reverting this SHA needs to be reverted with the next SHA to get back into a valid state.

The change removes the fact that `NgStyle`/`NgClass` is special and colaborates with the `[style]`/`[class]` to merge its styles. By reverting to old behavior we have better backwards compatiblity since it is no longer treated special and simply overwrites the styles (same as VE)

PR Close #34616
This commit is contained in:
Miško Hevery
2020-01-03 15:30:40 -08:00
parent 4005815114
commit 69de7680f5
12 changed files with 172 additions and 1014 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tools/public_api_guard/common/common.d.ts vendored
View File

@ -189,25 +189,15 @@ export declare class LowerCasePipe implements PipeTransform {
transform(value: string): string;
}
export declare class NgClass extends NgClassBase implements DoCheck {
export declare class NgClass implements DoCheck {
set klass(value: string);
set ngClass(value: string | string[] | Set<string> | {
[klass: string]: any;
});
constructor(delegate: NgClassImpl);
constructor(_iterableDiffers: IterableDiffers, _keyValueDiffers: KeyValueDiffers, _ngEl: ElementRef, _renderer: Renderer2);
ngDoCheck(): void;
}
export declare class NgClassBase {
protected _delegate: NgClassImpl;
constructor(_delegate: NgClassImpl);
getValue(): {
[key: string]: any;
} | null;
static ɵdir: any;
static ɵfac: any;
}
export declare class NgComponentOutlet implements OnChanges, OnDestroy {
ngComponentOutlet: Type<any>;
ngComponentOutletContent: any[][];
@ -275,24 +265,14 @@ export declare class NgPluralCase {
constructor(value: string, template: TemplateRef<Object>, viewContainer: ViewContainerRef, ngPlural: NgPlural);
}
export declare class NgStyle extends NgStyleBase implements DoCheck {
set ngStyle(value: {
export declare class NgStyle implements DoCheck {
set ngStyle(values: {
[klass: string]: any;
} | null);
constructor(delegate: NgStyleImpl);
constructor(_ngEl: ElementRef, _differs: KeyValueDiffers, _renderer: Renderer2);
ngDoCheck(): void;
}
export declare class NgStyleBase {
protected _delegate: NgStyleImpl;
constructor(_delegate: NgStyleImpl);
getValue(): {
[key: string]: any;
} | null;
static ɵdir: any;
static ɵfac: any;
}
export declare class NgSwitch {
set ngSwitch(newValue: any);
}