cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): enable more docs examples e2e tests (#28688)

Browse Source 
PR Close #28688
This commit is contained in:
Marc Laval 2019-02-13 14:37:43 +01:00 committed by Miško Hevery
parent 73f9db53c2
commit 6a7fd70ddf
1 changed files with 150 additions and 128 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

278
aio/tools/examples/run-example-e2e.js
View File

@ -15,11 +15,25 @@ const PROTRACTOR_CONFIG_FILENAME = path.join(__dirname, './shared/protractor.con
const SJS_SPEC_FILENAME = 'e2e-spec.ts'; const SJS_SPEC_FILENAME = 'e2e-spec.ts';
const CLI_SPEC_FILENAME = 'e2e/src/app.e2e-spec.ts'; const CLI_SPEC_FILENAME = 'e2e/src/app.e2e-spec.ts';
const EXAMPLE_CONFIG_FILENAME = 'example-config.json'; const EXAMPLE_CONFIG_FILENAME = 'example-config.json';
const IGNORED_EXAMPLES = [ // temporary ignores const IGNORED_EXAMPLES = [
// temporary ignores
'quickstart', 'quickstart',
'setup', 'setup',
]; ];
const fixmeIvyExamples = [
// fixmeIvy('unknown') version value goes undefined when clicking Major button after clicking
// Minor button twice
'component-interaction',
// fixmeIvy('unknown') failed content projection and applied styles
'component-styles',
// fixmeIvy('unknown') ERROR Error: Unable to find context associated with [object
// HTMLInputElement]
'http',
// fixmeIvy('unknown') app fails at runtime due to missing external service (goog is undefined)
'i18n'
];
/** /**
* Run Protractor End-to-End Tests for Doc Samples * Run Protractor End-to-End Tests for Doc Samples
* *
@ -45,29 +59,29 @@ function runE2e() {
console.log('runE2e: setup boilerplate'); console.log('runE2e: setup boilerplate');
const installPackagesCommand = `example-use-${argv.local ? 'local' : 'npm'}`; const installPackagesCommand = `example-use-${argv.local ? 'local' : 'npm'}`;
const addBoilerplateCommand = 'boilerplate:add'; const addBoilerplateCommand = 'boilerplate:add';
shelljs.exec(`yarn ${installPackagesCommand}`, { cwd: AIO_PATH }); shelljs.exec(`yarn ${installPackagesCommand}`, {cwd: AIO_PATH});
shelljs.exec(`yarn ${addBoilerplateCommand}`, { cwd: AIO_PATH }); shelljs.exec(`yarn ${addBoilerplateCommand}`, {cwd: AIO_PATH});
} }
const outputFile = path.join(AIO_PATH, './protractor-results.txt'); const outputFile = path.join(AIO_PATH, './protractor-results.txt');
return Promise.resolve() return Promise.resolve()
.then(() => findAndRunE2eTests(argv.filter, outputFile, argv.shard)) .then(() => findAndRunE2eTests(argv.filter, outputFile, argv.shard))
.then((status) => { .then((status) => {
reportStatus(status, outputFile); reportStatus(status, outputFile);
if (status.failed.length > 0) { if (status.failed.length > 0) {
return Promise.reject('Some test suites failed'); return Promise.reject('Some test suites failed');
} }
}).catch(function (e) { })
console.log(e); .catch(function(e) {
process.exitCode = 1; console.log(e);
}); process.exitCode = 1;
});
} }
// Finds all of the *e2e-spec.tests under the examples folder along with the corresponding apps // Finds all of the *e2e-spec.tests under the examples folder along with the corresponding apps
// that they should run under. Then run each app/spec collection sequentially. // that they should run under. Then run each app/spec collection sequentially.
function findAndRunE2eTests(filter, outputFile, shard) { function findAndRunE2eTests(filter, outputFile, shard) {
const shardParts = shard ? shard.split('/') : [0, 1]; const shardParts = shard ? shard.split('/') : [0, 1];
const shardModulo = parseInt(shardParts[0], 10); const shardModulo = parseInt(shardParts[0], 10);
const shardDivider = parseInt(shardParts[1], 10); const shardDivider = parseInt(shardParts[1], 10);
@ -79,45 +93,48 @@ function findAndRunE2eTests(filter, outputFile, shard) {
fs.writeFileSync(outputFile, header); fs.writeFileSync(outputFile, header);
// Run the tests sequentially. // Run the tests sequentially.
const status = { passed: [], failed: [] }; const status = {passed: [], failed: []};
return getE2eSpecs(EXAMPLES_PATH, filter) return getE2eSpecs(EXAMPLES_PATH, filter)
.then(e2eSpecPaths => { .then(e2eSpecPaths => {
console.log('All e2e specs:'); console.log('All e2e specs:');
logSpecs(e2eSpecPaths); logSpecs(e2eSpecPaths);
Object.keys(e2eSpecPaths).forEach(key => { Object.keys(e2eSpecPaths).forEach(key => {
const value = e2eSpecPaths[key]; const value = e2eSpecPaths[key];
e2eSpecPaths[key] = value.filter((p, index) => index % shardDivider === shardModulo); e2eSpecPaths[key] = value.filter((p, index) => index % shardDivider === shardModulo);
});
console.log(`E2e specs for shard ${shardParts.join('/')}:`);
logSpecs(e2eSpecPaths);
return e2eSpecPaths.systemjs.reduce((promise, specPath) => {
return promise.then(() => {
const examplePath = path.dirname(specPath);
return runE2eTestsSystemJS(examplePath, outputFile).then(ok => {
const arr = ok ? status.passed : status.failed;
arr.push(examplePath);
});
}); });
}, Promise.resolve())
.then(() => { console.log(`E2e specs for shard ${shardParts.join('/')}:`);
return e2eSpecPaths.cli.reduce((promise, specPath) => { logSpecs(e2eSpecPaths);
return promise.then(() => {
return runE2eTestsCLI(specPath, outputFile).then(ok => { return e2eSpecPaths.systemjs
const arr = ok ? status.passed : status.failed; .reduce(
arr.push(specPath); (promise, specPath) => {
return promise.then(() => {
const examplePath = path.dirname(specPath);
return runE2eTestsSystemJS(examplePath, outputFile).then(ok => {
const arr = ok ? status.passed : status.failed;
arr.push(examplePath);
});
});
},
Promise.resolve())
.then(() => {
return e2eSpecPaths.cli.reduce((promise, specPath) => {
return promise.then(() => {
return runE2eTestsCLI(specPath, outputFile).then(ok => {
const arr = ok ? status.passed : status.failed;
arr.push(specPath);
});
});
}, Promise.resolve());
}); });
}); })
}, Promise.resolve()); .then(() => {
const stopTime = new Date().getTime();
status.elapsedTime = (stopTime - startTime) / 1000;
return status;
}); });
})
.then(() => {
const stopTime = new Date().getTime();
status.elapsedTime = (stopTime - startTime) / 1000;
return status;
});
} }
// Start the example in appDir; then run protractor with the specified // Start the example in appDir; then run protractor with the specified
@ -127,8 +144,8 @@ function findAndRunE2eTests(filter, outputFile, shard) {
function runE2eTestsSystemJS(appDir, outputFile) { function runE2eTestsSystemJS(appDir, outputFile) {
const config = loadExampleConfig(appDir); const config = loadExampleConfig(appDir);
const appBuildSpawnInfo = spawnExt('yarn', [config.build], { cwd: appDir }); const appBuildSpawnInfo = spawnExt('yarn', [config.build], {cwd: appDir});
const appRunSpawnInfo = spawnExt('yarn', [config.run, '-s'], { cwd: appDir }, true); const appRunSpawnInfo = spawnExt('yarn', [config.run, '-s'], {cwd: appDir}, true);
let run = runProtractorSystemJS(appBuildSpawnInfo.promise, appDir, appRunSpawnInfo, outputFile); let run = runProtractorSystemJS(appBuildSpawnInfo.promise, appDir, appRunSpawnInfo, outputFile);
@ -141,40 +158,40 @@ function runE2eTestsSystemJS(appDir, outputFile) {
function runProtractorSystemJS(prepPromise, appDir, appRunSpawnInfo, outputFile) { function runProtractorSystemJS(prepPromise, appDir, appRunSpawnInfo, outputFile) {
const specFilename = path.resolve(`${appDir}/${SJS_SPEC_FILENAME}`); const specFilename = path.resolve(`${appDir}/${SJS_SPEC_FILENAME}`);
return prepPromise return prepPromise
.catch(function () { .catch(function() {
const emsg = `Application at ${appDir} failed to transpile.\n\n`; const emsg = `Application at ${appDir} failed to transpile.\n\n`;
console.log(emsg); console.log(emsg);
fs.appendFileSync(outputFile, emsg); fs.appendFileSync(outputFile, emsg);
return Promise.reject(emsg); return Promise.reject(emsg);
}) })
.then(function () { .then(function() {
let transpileError = false; let transpileError = false;
// Start protractor. // Start protractor.
console.log(`\n\n=========== Running aio example tests for: ${appDir}`); console.log(`\n\n=========== Running aio example tests for: ${appDir}`);
const spawnInfo = spawnExt('yarn', ['protractor', const spawnInfo = spawnExt(
PROTRACTOR_CONFIG_FILENAME, 'yarn',
`--specs=${specFilename}`, [
'--params.appDir=' + appDir, 'protractor', PROTRACTOR_CONFIG_FILENAME, `--specs=${specFilename}`,
'--params.outputFile=' + outputFile '--params.appDir=' + appDir, '--params.outputFile=' + outputFile
], { cwd: SHARED_PATH }); ],
{cwd: SHARED_PATH});
spawnInfo.proc.stderr.on('data', function (data) { spawnInfo.proc.stderr.on('data', function(data) {
transpileError = transpileError || /npm ERR! Exit status 100/.test(data.toString()); transpileError = transpileError || /npm ERR! Exit status 100/.test(data.toString());
}); });
return spawnInfo.promise.catch(function () { return spawnInfo.promise.catch(function() {
if (transpileError) { if (transpileError) {
const emsg = `${specFilename} failed to transpile.\n\n`; const emsg = `${specFilename} failed to transpile.\n\n`;
console.log(emsg); console.log(emsg);
fs.appendFileSync(outputFile, emsg); fs.appendFileSync(outputFile, emsg);
} }
return Promise.reject(); return Promise.reject();
}); });
}) })
.then( .then(
function () { return finish(appRunSpawnInfo.proc.pid, true); }, function() { return finish(appRunSpawnInfo.proc.pid, true); },
function () { return finish(appRunSpawnInfo.proc.pid, false); } function() { return finish(appRunSpawnInfo.proc.pid, false); });
);
} }
function finish(spawnProcId, ok) { function finish(spawnProcId, ok) {
@ -187,14 +204,14 @@ function finish(spawnProcId, ok) {
// Run e2e tests over the AOT build for projects that examples it. // Run e2e tests over the AOT build for projects that examples it.
function runProtractorAoT(appDir, outputFile) { function runProtractorAoT(appDir, outputFile) {
fs.appendFileSync(outputFile, '++ AoT version ++\n'); fs.appendFileSync(outputFile, '++ AoT version ++\n');
const aotBuildSpawnInfo = spawnExt('yarn', ['build:aot'], { cwd: appDir }); const aotBuildSpawnInfo = spawnExt('yarn', ['build:aot'], {cwd: appDir});
let promise = aotBuildSpawnInfo.promise; let promise = aotBuildSpawnInfo.promise;
const copyFileCmd = 'copy-dist-files.js'; const copyFileCmd = 'copy-dist-files.js';
if (fs.existsSync(appDir + '/' + copyFileCmd)) { if (fs.existsSync(appDir + '/' + copyFileCmd)) {
promise = promise.then(() => spawnExt('node', [copyFileCmd], { cwd: appDir }).promise); promise = promise.then(() => spawnExt('node', [copyFileCmd], {cwd: appDir}).promise);
} }
const aotRunSpawnInfo = spawnExt('yarn', ['serve:aot'], { cwd: appDir }, true); const aotRunSpawnInfo = spawnExt('yarn', ['serve:aot'], {cwd: appDir}, true);
return runProtractorSystemJS(promise, appDir, aotRunSpawnInfo, outputFile); return runProtractorSystemJS(promise, appDir, aotRunSpawnInfo, outputFile);
} }
@ -206,11 +223,15 @@ function runE2eTestsCLI(appDir, outputFile) {
console.log(`\n\n=========== Running aio example tests for: ${appDir}`); console.log(`\n\n=========== Running aio example tests for: ${appDir}`);
// `--no-webdriver-update` is needed to preserve the ChromeDriver version already installed. // `--no-webdriver-update` is needed to preserve the ChromeDriver version already installed.
const config = loadExampleConfig(appDir); const config = loadExampleConfig(appDir);
const commands = config.e2e || [{ cmd: 'yarn', args: ['e2e', '--no-webdriver-update'] }]; <<<<<<< HEAD
const commands = config.e2e || [{cmd: 'yarn', args: ['e2e', '--no-webdriver-update']}];
=======
const commands = config.e2e || [{cmd: 'yarn', args: ['e2e', '--prod', '--no-webdriver-update']}];
>>>>>>> c8a0ce7388... test(ivy): enable more docs examples e2e tests (#28688)
const e2eSpawnPromise = commands.reduce((prevSpawnPromise, { cmd, args }) => { const e2eSpawnPromise = commands.reduce((prevSpawnPromise, {cmd, args}) => {
return prevSpawnPromise.then(() => { return prevSpawnPromise.then(() => {
const currSpawn = spawnExt(cmd, args, { cwd: appDir }); const currSpawn = spawnExt(cmd, args, {cwd: appDir});
return currSpawn.promise.then( return currSpawn.promise.then(
() => Promise.resolve(finish(currSpawn.proc.pid, true)), () => Promise.resolve(finish(currSpawn.proc.pid, true)),
() => Promise.reject(finish(currSpawn.proc.pid, false))); () => Promise.reject(finish(currSpawn.proc.pid, false)));
@ -218,25 +239,27 @@ function runE2eTestsCLI(appDir, outputFile) {
}, Promise.resolve()); }, Promise.resolve());
return e2eSpawnPromise.then( return e2eSpawnPromise.then(
() => { fs.appendFileSync(outputFile, `Passed: ${appDir}\n\n`); return true; }, () => {
() => { fs.appendFileSync(outputFile, `Failed: ${appDir}\n\n`); return false; }); fs.appendFileSync(outputFile, `Passed: ${appDir}\n\n`);
return true;
},
() => {
fs.appendFileSync(outputFile, `Failed: ${appDir}\n\n`);
return false;
});
} }
// Report final status. // Report final status.
function reportStatus(status, outputFile) { function reportStatus(status, outputFile) {
let log = ['']; let log = [''];
log.push('Suites passed:'); log.push('Suites passed:');
status.passed.forEach(function (val) { status.passed.forEach(function(val) { log.push(' ' + val); });
log.push(' ' + val);
});
if (status.failed.length == 0) { if (status.failed.length == 0) {
log.push('All tests passed'); log.push('All tests passed');
} else { } else {
log.push('Suites failed:'); log.push('Suites failed:');
status.failed.forEach(function (val) { status.failed.forEach(function(val) { log.push(' ' + val); });
log.push(' ' + val);
});
} }
log.push('\nElapsed time: ' + status.elapsedTime + ' seconds'); log.push('\nElapsed time: ' + status.elapsedTime + ' seconds');
log = log.join('\n'); log = log.join('\n');
@ -255,68 +278,67 @@ function spawnExt(command, args, options, ignoreClose = false) {
} catch (e) { } catch (e) {
console.log(e); console.log(e);
reject(e); reject(e);
return { proc: null, promise }; return {proc: null, promise};
} }
proc.stdout.on('data', function (data) { proc.stdout.on('data', function(data) { process.stdout.write(data.toString()); });
process.stdout.write(data.toString()); proc.stderr.on('data', function(data) { process.stdout.write(data.toString()); });
}); proc.on('close', function(returnCode) {
proc.stderr.on('data', function (data) {
process.stdout.write(data.toString());
});
proc.on('close', function (returnCode) {
console.log(`completed: ${descr} \n`); console.log(`completed: ${descr} \n`);
// Many tasks (e.g., tsc) complete but are actually errors; // Many tasks (e.g., tsc) complete but are actually errors;
// Confirm return code is zero. // Confirm return code is zero.
returnCode === 0 || ignoreClose ? resolve(0) : reject(returnCode); returnCode === 0 || ignoreClose ? resolve(0) : reject(returnCode);
}); });
proc.on('error', function (data) { proc.on('error', function(data) {
console.log(`completed with error: ${descr} \n`); console.log(`completed with error: ${descr} \n`);
console.log(data.toString()); console.log(data.toString());
reject(data); reject(data);
}); });
}); });
return { proc, promise }; return {proc, promise};
} }
function getE2eSpecs(basePath, filter) { function getE2eSpecs(basePath, filter) {
let specs = {}; let specs = {};
return getE2eSpecsFor(basePath, SJS_SPEC_FILENAME, filter).then(sjsPaths => { return getE2eSpecsFor(basePath, SJS_SPEC_FILENAME, filter)
specs.systemjs = sjsPaths; .then(sjsPaths => { specs.systemjs = sjsPaths; })
}).then(() => { .then(() => {
return getE2eSpecsFor(basePath, CLI_SPEC_FILENAME, filter).then(cliPaths => { return getE2eSpecsFor(basePath, CLI_SPEC_FILENAME, filter).then(cliPaths => {
return cliPaths.map(p => { return cliPaths.map(p => { return p.replace(`${CLI_SPEC_FILENAME}`, ''); });
return p.replace(`${CLI_SPEC_FILENAME}`, ''); });
}); })
}); .then(cliPaths => { specs.cli = cliPaths; })
}).then(cliPaths => { .then(() => specs);
specs.cli = cliPaths;
}).then(() => specs);
} }
// Find all e2e specs in a given example folder. // Find all e2e specs in a given example folder.
function getE2eSpecsFor(basePath, specFile, filter) { function getE2eSpecsFor(basePath, specFile, filter) {
// Only get spec file at the example root. // Only get spec file at the example root.
const e2eSpecGlob = `${filter ? `*${filter}*` : '*'}/${specFile}`; <<<<<<< HEAD
return globby(e2eSpecGlob, { cwd: basePath, nodir: true }) const e2eSpecGlob = `${filter ? ` * ${filter} * ` : '*'}/${specFile}`;
.then(paths => paths return globby(e2eSpecGlob, {cwd: basePath, nodir: true})
.filter(file => !IGNORED_EXAMPLES.some(ignored => file.startsWith(ignored))) .then(
.map(file => path.join(basePath, file)) paths => paths.filter(file => !IGNORED_EXAMPLES.some(ignored => file.startsWith(ignored)))
); .map(file => path.join(basePath, file)));
=======
const e2eSpecGlob = `${filter ? '*' + filter + '*' : '*'}/${specFile}`;
return globby(e2eSpecGlob, {cwd: basePath, nodir: true})
.then(
paths => paths.filter(file => !IGNORED_EXAMPLES.some(ignored => file.startsWith(ignored)))
.map(file => path.join(basePath, file)));
>>>>>>> c8a0ce7388... test(ivy): enable more docs examples e2e tests (#28688)
} }
// Load configuration for an example. Used for SystemJS // Load configuration for an example. Used for SystemJS
function loadExampleConfig(exampleFolder) { function loadExampleConfig(exampleFolder) {
// Default config. // Default config.
let config = { let config = {build: 'build', run: 'serve:e2e'};
build: 'build',
run: 'serve:e2e'
};
try { try {
const exampleConfig = fs.readJsonSync(`${exampleFolder}/${EXAMPLE_CONFIG_FILENAME}`); const exampleConfig = fs.readJsonSync(`${exampleFolder}/${EXAMPLE_CONFIG_FILENAME}`);
Object.assign(config, exampleConfig); Object.assign(config, exampleConfig);
} catch (e) { } } catch (e) {
}
return config; return config;
} }