cargdev/angular
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update scripting and tooling to rely on define=angular_ivy_enabled instream of define=compile (#33983)

Browse Source 
We need to migrate to using angular_ivy_enabled value to determine whether to use
Ivy or ViewEngine for package building scripts and for size-tracking and
symbol-extract tooling.

PR Close #33983
This commit is contained in:
Joey Perrott
2019-11-22 12:11:48 -08:00
committed by Matias Niemelä
parent fec9f7dce5
commit 6bf258178d
10 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/size-tracking/index.bzl
View File

@ -18,7 +18,7 @@ def js_size_tracking_test(
golden_file,
max_percentage_diff,
max_byte_diff,
required_compile_mode = "",
angular_ivy_enabled = "False",
data = [],
**kwargs):
all_data = data + [
@ -32,7 +32,7 @@ def js_size_tracking_test(
name = name,
data = all_data,
entry_point = entry_point,
configuration_env_vars = ["compile"],
configuration_env_vars = ["angular_ivy_enabled"],
templated_args = [
src,
source_map,
@ -40,7 +40,7 @@ def js_size_tracking_test(
"%d" % max_percentage_diff,
"%d" % max_byte_diff,
"false",
required_compile_mode,
angular_ivy_enabled,
],
**kwargs
)
@ -50,7 +50,7 @@ def js_size_tracking_test(
testonly = True,
data = all_data,
entry_point = entry_point,
configuration_env_vars = ["compile"],
templated_args = [src, source_map, golden_file, "0", "0", "true", required_compile_mode],
configuration_env_vars = ["angular_ivy_enabled"],
templated_args = [src, source_map, golden_file, "0", "0", "true", angular_ivy_enabled],
**kwargs
)

12
tools/size-tracking/index.ts
View File

@ -26,14 +26,14 @@ if (require.main === module) {
export function main(
filePath: string, sourceMapPath: string, goldenSizeMapPath: string, writeGolden: boolean,
maxPercentageDiff: number, maxByteDiff: number, requiredCompileMode: string): boolean {
maxPercentageDiff: number, maxByteDiff: number, requiresIvy: string): boolean {
const {sizeResult} = new SizeTracker(filePath, sourceMapPath);
const compileMode = process.env['compile'];
const ivyEnabled = process.env['angular_ivy_enabled'] == 'True';
if (requiredCompileMode && compileMode !== requiredCompileMode) {
if (requiresIvy && ivyEnabled) {
console.error(chalk.red(
`Expected the size-tracking tool to be run with: ` +
`--define=compile=${requiredCompileMode}`));
`--config=${requiresIvy ? 'ivy' : 'view-engine'}`));
return false;
}
@ -60,9 +60,9 @@ export function main(
});
const bazelTargetName = process.env['TEST_TARGET'];
const defineFlag = (compileMode !== 'legacy') ? `--define=compile=${compileMode} ` : '';
console.error(`\nThe golden file can be updated with the following command:`);
console.error(` yarn bazel run ${defineFlag}${bazelTargetName}.accept`);
console.error(
` yarn bazel run --config=${ivyEnabled ? 'ivy' : 'view-engine'} ${bazelTargetName}.accept`);
return false;
}