cargdev/angular
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update scripting and tooling to rely on define=angular_ivy_enabled instream of define=compile (#33983)

Browse Source 
We need to migrate to using angular_ivy_enabled value to determine whether to use
Ivy or ViewEngine for package building scripts and for size-tracking and
symbol-extract tooling.

PR Close #33983
This commit is contained in:
Joey Perrott
2019-11-22 12:11:48 -08:00
committed by Matias Niemelä
parent fec9f7dce5
commit 6bf258178d
10 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/symbol-extractor/cli.ts
View File

@ -39,11 +39,11 @@ function main(argv: [string, string, string] | [string, string]): boolean {
} else {
passed = symbolExtractor.compareAndPrintError(goldenFilePath, goldenContent);
if (!passed) {
const compile = process.env['compile'];
const defineFlag = (compile !== 'legacy') ? `--define=compile=${compile} ` : '';
const ivyEnabled = process.env['angular_ivy_enabled'] == 'True';
console.error(`TEST FAILED!`);
console.error(` To update the golden file run: `);
console.error(` yarn bazel run ${defineFlag}${process.env['TEST_TARGET']}.accept`);
console.error(
` yarn bazel run --config=${ivyEnabled ? 'ivy' : 'view-engine'} ${process.env['TEST_TARGET']}.accept`);
}
}
return passed;