cargdev/angular
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(upgrade): use a constant for $exceptionHandler (#26217)

Browse Source 
PR Close #26217
This commit is contained in:
George Kalpakas
2018-10-11 17:44:59 +03:00
committed by Kara Erickson
parent 099d1a67a0
commit 6c5c97b2f9
5 changed files with 23 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/upgrade/test/static/integration/downgrade_component_spec.ts
View File

@ -22,18 +22,15 @@ withEachNg1Version(() => {
afterEach(() => destroyPlatform());
it('should bind properties, events', async(() => {
const ng1Module =
angular.module('ng1', []).value('$exceptionHandler', (err: any) => {
throw err;
}).run(($rootScope: angular.IScope) => {
$rootScope['name'] = 'world';
$rootScope['dataA'] = 'A';
$rootScope['dataB'] = 'B';
$rootScope['modelA'] = 'initModelA';
$rootScope['modelB'] = 'initModelB';
$rootScope['eventA'] = '?';
$rootScope['eventB'] = '?';
});
const ng1Module = angular.module('ng1', []).run(($rootScope: angular.IScope) => {
$rootScope['name'] = 'world';
$rootScope['dataA'] = 'A';
$rootScope['dataB'] = 'B';
$rootScope['modelA'] = 'initModelA';
$rootScope['modelB'] = 'initModelB';
$rootScope['eventA'] = '?';
$rootScope['eventB'] = '?';
});
@Component({
selector: 'ng2',
@ -149,12 +146,8 @@ withEachNg1Version(() => {
}));
it('should bind properties to onpush components', async(() => {
const ng1Module =
angular.module('ng1', []).value('$exceptionHandler', (err: any) => {
throw err;
}).run(($rootScope: angular.IScope) => {
$rootScope['dataB'] = 'B';
});
const ng1Module = angular.module('ng1', []).run(
($rootScope: angular.IScope) => { $rootScope['dataB'] = 'B'; });
@Component({
selector: 'ng2',