cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): use presence of .subscribe to detect observables rather then Symbol.observable (#15171)

Browse Source 
Fixes #14298
Fixes #14473
Fixes #14926
This commit is contained in:
Dzmitry Shylovich
2017-03-16 03:13:03 +03:00
committed by Chuck Jazdzewski
parent 313158132d
commit 6e98757665
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/test/util/lang_spec.ts
View File

@ -30,6 +30,9 @@ export function main() {
describe('isObservable', () => {
it('should be true for an Observable', () => expect(isObservable(of (true))).toEqual(true));
it('should be true if the argument is the object with subscribe function',
() => expect(isObservable({subscribe: () => {}})).toEqual(true));
it('should be false if the argument is undefined',
() => expect(isObservable(undefined)).toEqual(false));
@ -40,8 +43,5 @@ export function main() {
it('should be false if the argument is a function',
() => expect(isObservable(() => {})).toEqual(false));
it('should be false if the argument is the object with subscribe function',
() => expect(isObservable({subscribe: () => {}})).toEqual(false));
});
}