From 6eb868b63a5b0ae877346b48ac659f35e6e7af8b Mon Sep 17 00:00:00 2001 From: Olivier Combe Date: Wed, 8 Jul 2020 16:23:02 +0200 Subject: [PATCH] build(compiler-cli): fix bazel deps rules for ngtsc testing packages (#37977) The ngtsc testing packages for file_system and logging were missing from the bazel deps rules, which means that they were not included in the releases PR Close #37977 --- packages/compiler-cli/BUILD.bazel | 2 ++ .../compiler-cli/src/ngtsc/file_system/testing/BUILD.bazel | 3 ++- packages/compiler-cli/src/ngtsc/logging/testing/BUILD.bazel | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/compiler-cli/BUILD.bazel b/packages/compiler-cli/BUILD.bazel index cb3c783dd7..27885e70af 100644 --- a/packages/compiler-cli/BUILD.bazel +++ b/packages/compiler-cli/BUILD.bazel @@ -61,6 +61,8 @@ pkg_npm( deps = [ ":compiler-cli", "//packages/compiler-cli/ngcc", + "//packages/compiler-cli/src/ngtsc/file_system/testing", + "//packages/compiler-cli/src/ngtsc/logging/testing", ], ) diff --git a/packages/compiler-cli/src/ngtsc/file_system/testing/BUILD.bazel b/packages/compiler-cli/src/ngtsc/file_system/testing/BUILD.bazel index e28599e6ae..e308d58449 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/testing/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/file_system/testing/BUILD.bazel @@ -4,13 +4,14 @@ package(default_visibility = ["//visibility:public"]) ts_library( name = "testing", - testonly = True, srcs = glob([ "**/*.ts", ]), deps = [ "//packages:types", "//packages/compiler-cli/src/ngtsc/file_system", + "@npm//@types/jasmine", + "@npm//@types/node", "@npm//typescript", ], ) diff --git a/packages/compiler-cli/src/ngtsc/logging/testing/BUILD.bazel b/packages/compiler-cli/src/ngtsc/logging/testing/BUILD.bazel index cb58355631..9c1ed58644 100644 --- a/packages/compiler-cli/src/ngtsc/logging/testing/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/logging/testing/BUILD.bazel @@ -4,7 +4,6 @@ package(default_visibility = ["//visibility:public"]) ts_library( name = "testing", - testonly = True, srcs = glob([ "**/*.ts", ]),