build: TypeScript 3.5 upgrade (#31615)

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35

PR Close #31615

packages/compiler-cli/package.json

@@ -23,7 +23,7 @@
   },
   "peerDependencies": {
     "@angular/compiler": "0.0.0-PLACEHOLDER",
-    "typescript": ">=3.4 <3.5"
+    "typescript": ">=3.4 <3.6"
   },
   "engines": {
     "node": ">=8.0"

packages/compiler-cli/src/main.ts

@@ -106,8 +106,8 @@ function createEmitCallback(options: api.CompilerOptions): api.TsEmitCallback|un
            }) =>
                // tslint:disable-next-line:no-require-imports only depend on tsickle if requested
         require('tsickle').emitWithTsickle(
-            program, {...tsickleHost, options, host}, host, options, targetSourceFile, writeFile,
-            cancellationToken, emitOnlyDtsFiles, {
+            program, {...tsickleHost, options, host, moduleResolutionHost: host}, host, options,
+            targetSourceFile, writeFile, cancellationToken, emitOnlyDtsFiles, {
               beforeTs: customTransformers.before,
               afterTs: customTransformers.after,
             });

packages/compiler-cli/src/metadata/schema.ts

@@ -59,6 +59,7 @@ export interface MetadataMap { [name: string]: MemberMetadata[]; }
 export interface MemberMetadata {
   __symbolic: 'constructor'|'method'|'property';
   decorators?: (MetadataSymbolicExpression|MetadataError)[];
+  parameters?: (MetadataSymbolicExpression|MetadataError|null|undefined)[];
 }
 export function isMemberMetadata(value: any): value is MemberMetadata {
   if (value) {

packages/compiler-cli/src/transformers/program.ts

@@ -79,7 +79,7 @@ const MIN_TS_VERSION = '3.4.0';
  * ∀ supported typescript version v, v < MAX_TS_VERSION
  * MAX_TS_VERSION is not considered as a supported TypeScript version
  */
-const MAX_TS_VERSION = '3.5.0';
+const MAX_TS_VERSION = '3.6.0';
 
 class AngularCompilerProgram implements Program {
   private rootNames: string[];

packages/compiler-cli/test/diagnostics/check_types_spec.ts

@@ -771,12 +771,6 @@ describe('ng type checker', () => {
           '<div>{{"hello" | aPipe}}</div>',
           `Argument of type '"hello"' is not assignable to parameter of type 'number'.`, '0:5');
     });
-    it('should report an index into a map expression', () => {
-      rejectOnlyWithFullTemplateTypeCheck(
-          '<div>{{ {a: 1}[name] }}</div>',
-          `Element implicitly has an 'any' type because type '{ a: number; }' has no index signature.`,
-          '0:5');
-    });
     it('should report an invalid property on an exportAs directive', () => {
       rejectOnlyWithFullTemplateTypeCheck(
           '<div aDir #aDir="aDir">{{aDir.fname}}</div>',

packages/compiler-cli/test/metadata/collector_spec.ts

@@ -60,7 +60,7 @@ describe('Collector', () => {
       version: METADATA_VERSION,
       metadata: {
         DeclaredClass: {__symbolic: 'class'},
-        declaredFn: {__symbolic: 'function'},
+        declaredFn: {__symbolic: 'function'} as any,
       }
     });
   });
@@ -433,8 +433,8 @@ describe('Collector', () => {
             }
           }
         },
-        complexFn: {__symbolic: 'function'},
-        declaredFn: {__symbolic: 'function'}
+        complexFn: {__symbolic: 'function'} as any,
+        declaredFn: {__symbolic: 'function'} as any,
       }
     });
   });

packages/compiler-cli/test/ngtsc/ngtsc_spec.ts

@@ -3144,7 +3144,7 @@ runInEachFileSystem(os => {
           const fileoverview = `
         /**
          * @fileoverview added by tsickle
-         * @suppress {checkTypes,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
+         * @suppress {checkTypes,constantProperty,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
          */
       `;
           expect(trim(jsContents).startsWith(trim(fileoverview))).toBeTruthy();
@@ -3161,7 +3161,7 @@ runInEachFileSystem(os => {
           const fileoverview = `
         /**
          * @fileoverview added by tsickle
-         * @suppress {checkTypes,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
+         * @suppress {checkTypes,constantProperty,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
          */
       `;
           expect(trim(jsContents).startsWith(trim(fileoverview))).toBeTruthy();
@@ -3193,7 +3193,7 @@ runInEachFileSystem(os => {
          * @fileoverview Some Comp overview
          * @modName {some_comp}
          *
-         * @suppress {checkTypes,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
+         * @suppress {checkTypes,constantProperty,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
          */
       `;
           expect(trim(jsContents).startsWith(trim(fileoverview))).toBeTruthy();
@@ -3222,7 +3222,7 @@ runInEachFileSystem(os => {
          * @fileoverview Some Comp overview
          * @modName {some_comp}
          *
-         * @suppress {checkTypes,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
+         * @suppress {checkTypes,constantProperty,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc
          */
       `;
              expect(trim(jsContents).startsWith(trim(fileoverview))).toBeTruthy();

packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts

@@ -238,7 +238,7 @@ export declare class CommonModule {
         `'does_not_exist' does not exist on type '{ name: string; }'`,
         `Expected 2 arguments, but got 3.`,
         `Argument of type '"test"' is not assignable to parameter of type 'number'`,
-        `Argument of type '{ name: string; }' is not assignable to parameter of type '{}[]'`,
+        `Argument of type '{ name: string; }' is not assignable to parameter of type 'unknown[]'`,
       ];
 
       for (const error of allErrors) {