From 6f579b20f8ee219976fb2aebffb81f6abc549aa5 Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Thu, 10 Sep 2020 18:15:32 -0700 Subject: [PATCH] feat(dev-infra): output the number of new and fixed cycles (#38805) This commit adds a logic to ouput the number of new and fixed cycles after running circular dependency checker. This information is useful to better understand an impact of changes in case the number of new/fixed cycles is relatively big. PR Close #38805 --- dev-infra/ts-circular-dependencies/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev-infra/ts-circular-dependencies/index.ts b/dev-infra/ts-circular-dependencies/index.ts index fb90015f2f..e76ad4d7e1 100644 --- a/dev-infra/ts-circular-dependencies/index.ts +++ b/dev-infra/ts-circular-dependencies/index.ts @@ -112,7 +112,8 @@ export function main( if (fixedCircularDeps.length !== 0) { error(yellow(` Fixed circular dependencies that need to be removed from the golden:`)); fixedCircularDeps.forEach(c => error(` • ${convertReferenceChainToString(c)}`)); - error(); + info(yellow(`\n Total: ${newCircularDeps.length} new cycle(s), ${ + fixedCircularDeps.length} fixed cycle(s). \n`)); if (approveCommand) { info(yellow(` Please approve the new golden with: ${approveCommand}`)); } else {