cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(http): call complete on request complete

Browse Source 
closes #2635
This commit is contained in:
gdi2290 2015-07-27 16:59:09 -07:00 committed by Jeff Cross
parent 74b311a472
commit 6fac901151
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/angular2/src/http/backends/xhr_backend.ts
View File

@ -43,6 +43,8 @@ export class XHRConnection implements Connection {
} }
ObservableWrapper.callNext(this.response, new Response(responseOptions)); ObservableWrapper.callNext(this.response, new Response(responseOptions));
// TODO(gdi2290): defer complete if array buffer until done
ObservableWrapper.callReturn(this.response);
}); });
// TODO(jeffbcross): make this more dynamic based on body type // TODO(jeffbcross): make this more dynamic based on body type

10
modules/angular2/test/http/backends/xhr_backend_spec.ts
View File

@ -95,6 +95,16 @@ export function main() {
existingXHRs[0].dispatchEvent('load'); existingXHRs[0].dispatchEvent('load');
})); }));
it('should complete a request', inject([AsyncTestCompleter], async => {
var connection = new XHRConnection(sampleRequest, new MockBrowserXHR(),
new ResponseOptions({type: ResponseTypes.Error}));
ObservableWrapper.subscribe<Response>(connection.response, res => {
expect(res.type).toBe(ResponseTypes.Error);
}, null, () => { async.done(); });
existingXHRs[0].dispatchEvent('load');
}));
it('should call abort when disposed', () => { it('should call abort when disposed', () => {
var connection = new XHRConnection(sampleRequest, new MockBrowserXHR()); var connection = new XHRConnection(sampleRequest, new MockBrowserXHR());
connection.dispose(); connection.dispose();