From 70177e544bdbbfac3c2cc7521e8386d68682b76b Mon Sep 17 00:00:00 2001
From: George Kalpakas <kalpakas.g@gmail.com>
Date: Mon, 15 Apr 2019 15:46:14 +0300
Subject: [PATCH] build(docs-infra): add missing dependencies (chrome-launcher,
 lighthouse-logger) (#29904)

We are using `chrome-launcher` and `lighthouse-logger` in
[test-pwa-score][1], but we do not explicitly list them as
`devDependencies`, so we are relying on the fact that they happen to be
hoisted in `node_modules/` by yarn. This may unexpectedly break in the
future.

This commit fixes this, by explicitly listing them as `devDependencies`.

[1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18

PR Close #29904
---
 aio/package.json | 2 ++
 aio/yarn.lock    | 1 +
 2 files changed, 3 insertions(+)

diff --git a/aio/package.json b/aio/package.json
index f0064d1daa..93917d88e2 100644
--- a/aio/package.json
+++ b/aio/package.json
@@ -108,6 +108,7 @@
     "archiver": "^1.3.0",
     "canonical-path": "1.0.0",
     "chalk": "^2.1.0",
+    "chrome-launcher": "^0.10.5",
     "cjson": "^0.5.0",
     "codelyzer": "~4.5.0",
     "cross-spawn": "^5.1.0",
@@ -142,6 +143,7 @@
     "karma-jasmine": "^1.1.0",
     "karma-jasmine-html-reporter": "^0.2.2",
     "lighthouse": "^4.3.0",
+    "lighthouse-logger": "^1.2.0",
     "lodash": "^4.17.4",
     "lunr": "^2.1.0",
     "npm-run-all": "^4.1.5",
diff --git a/aio/yarn.lock b/aio/yarn.lock
index 890d656db7..a4724b52e5 100644
--- a/aio/yarn.lock
+++ b/aio/yarn.lock
@@ -1939,6 +1939,7 @@ chownr@^1.0.1, chownr@^1.1.1:
 chrome-launcher@^0.10.5:
   version "0.10.5"
   resolved "https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.10.5.tgz#d0aa72c11f1653e6a60dfebea171522447470ef1"
+  integrity sha512-Gbzg8HlWhyuoVqflhiXwfFXhzNfNWvAkSWv2QR1Yl6mwsMo1oCLAVjp2tIySuS4lrZLEjzVx1fOy584yE76P4g==
   dependencies:
     "@types/core-js" "^0.9.41"
     "@types/mkdirp" "^0.3.29"