cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(debug): make debug tools take ComponentRef

Browse Source 
The debug tools used to take ApplicationRefs, which are the old return
type of bootstrap. Now bootstrap returns ComponentRef, so the debug
tools should be updated.

Closes #4203
This commit is contained in:
Harry Terkelsen
2015-09-15 17:13:48 -07:00
committed by Harry Terkelsen
parent 8f985dd558
commit 70586b668c
7 changed files with 25 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/angular2/src/core/application_common.ts
View File

@ -219,7 +219,7 @@ export function platform(bindings?: Array<Type | Binding | any[]>): PlatformRef
* - `errorReporter`: `function(exception:any, stackTrace:string)` a default error reporter
* for unhandled exceptions.
*
* Returns a `Promise` of {@link ApplicationRef}.
* Returns a `Promise` of {@link ComponentRef}.
*/
export function commonBootstrap(appComponentType: /*Type*/ any,
appBindings: Array<Type | Binding | any[]> = null):

7
modules/angular2/src/tools/common_tools.ts
View File

@ -1,4 +1,5 @@
import {ApplicationRef, LifeCycle} from 'angular2/angular2';
import {LifeCycle} from 'angular2/angular2';
import {ComponentRef} from 'angular2/src/core/compiler/dynamic_component_loader';
import {isPresent, NumberWrapper} from 'angular2/src/core/facade/lang';
import {performance, window} from 'angular2/src/core/facade/browser';
import {DOM} from 'angular2/src/core/dom/dom_adapter';
@ -10,7 +11,7 @@ import {DOM} from 'angular2/src/core/dom/dom_adapter';
export class AngularTools {
profiler: AngularProfiler;
constructor(appRef: ApplicationRef) { this.profiler = new AngularProfiler(appRef); }
constructor(ref: ComponentRef) { this.profiler = new AngularProfiler(ref); }
}
/**
@ -20,7 +21,7 @@ export class AngularTools {
export class AngularProfiler {
lifeCycle: LifeCycle;
constructor(appRef: ApplicationRef) { this.lifeCycle = appRef.injector.get(LifeCycle); }
constructor(ref: ComponentRef) { this.lifeCycle = ref.injector.get(LifeCycle); }
/**
* Exercises change detection in a loop and then prints the average amount of

6
modules/angular2/src/tools/tools.dart
View File

@ -1,7 +1,7 @@
library angular2.src.tools.tools;
import 'dart:js';
import 'package:angular2/angular2.dart' show ApplicationRef;
import 'package:angular2/src/core/compiler/dynamic_component_loader.dart' show ComponentRef;
import 'common_tools.dart' show AngularTools;
/**
@ -15,8 +15,8 @@ import 'common_tools.dart' show AngularTools;
* 1. Try the change detection profiler `ng.profiler.timeChangeDetection()`
* then hit Enter.
*/
void enableDebugTools(ApplicationRef appRef) {
final tools = new AngularTools(appRef);
void enableDebugTools(ComponentRef ref) {
final tools = new AngularTools(ref);
context['ng'] = new JsObject.jsify({
'profiler': {
'timeChangeDetection': ([config]) {

6
modules/angular2/src/tools/tools.ts
View File

@ -1,5 +1,5 @@
import {global} from 'angular2/src/core/facade/lang';
import {ApplicationRef} from 'angular2/angular2';
import {ComponentRef} from 'angular2/src/core/compiler/dynamic_component_loader';
import {AngularTools} from './common_tools';
var context = <any>global;
@ -15,8 +15,8 @@ var context = <any>global;
* 1. Try the change detection profiler `ng.profiler.timeChangeDetection()`
* then hit Enter.
*/
export function enableDebugTools(appRef: ApplicationRef): void {
context.ng = new AngularTools(appRef);
export function enableDebugTools(ref: ComponentRef): void {
context.ng = new AngularTools(ref);
}
/**