cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(upgrade): share code for destroying upgraded components between dynamic and static (#25357)

Browse Source 
PR Close #25357
This commit is contained in:
George Kalpakas
2018-08-07 17:36:23 +03:00
committed by Misko Hevery
parent 51c26b8afb
commit 71007ef9b2
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/upgrade/src/common/upgrade_helper.ts
View File

@ -119,6 +119,13 @@ export class UpgradeHelper {
return this.compileHtml(template);
}
onDestroy($scope: angular.IScope, controllerInstance?: any) {
if (controllerInstance && isFunction(controllerInstance.$onDestroy)) {
controllerInstance.$onDestroy();
}
$scope.$destroy();
}
prepareTransclusion(): angular.ILinkFn|undefined {
const transclude = this.directive.transclude;
const contentChildNodes = this.extractChildNodes();