cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): Move LifeCycle functionality into ApplicationRef.

Browse Source 
BREAKING CHANGE:

Before: constructor(@Inject(LifeCycle) lifecycle) { lifecycle.tick(); }
After: constructor(@Inject(ApplicationRef) appRef) { appRef.tick(); }

Closes #5008
This commit is contained in:
Alex Rickabaugh
2015-10-28 10:34:13 -07:00
parent ef23fe66a0
commit 72e65d6797
19 changed files with 144 additions and 182 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/benchmarks/src/largetable/largetable_benchmark.ts
View File

@ -17,9 +17,9 @@ import {
NgFor,
NgSwitch,
NgSwitchWhen,
NgSwitchDefault,
LifeCycle
NgSwitchDefault
} from 'angular2/core';
import {ApplicationRef} from 'angular2/src/core/application_ref';
import {BrowserDomAdapter} from 'angular2/src/core/dom/browser_adapter';
import {APP_VIEW_POOL_CAPACITY} from 'angular2/src/core/linker/view_pool';
@ -65,7 +65,7 @@ export function main() {
BASELINE_LARGETABLE_TEMPLATE = DOM.createTemplate('<table></table>');
var app;
var lifecycle;
var appRef;
var baselineRootLargetableComponent;
function ng2DestroyDom() {
@ -73,7 +73,7 @@ export function main() {
// --> this should be already caught in change detection!
app.data = null;
app.benchmarkType = 'none';
lifecycle.tick();
appRef.tick();
}
function profile(create, destroy, name) {
@ -116,7 +116,7 @@ export function main() {
}
app.data = data;
app.benchmarkType = getStringParameter('benchmarkType');
lifecycle.tick();
appRef.tick();
}
function noop() {}
@ -126,7 +126,7 @@ export function main() {
.then((ref) => {
var injector = ref.injector;
app = ref.hostComponent;
lifecycle = injector.get(LifeCycle);
appRef = injector.get(ApplicationRef);
bindAction('#ng2DestroyDom', ng2DestroyDom);
bindAction('#ng2CreateDom', ng2CreateDom);
bindAction('#ng2UpdateDomProfile', profile(ng2CreateDom, noop, 'ng2-update'));