From 72fc0a747dec1c8141fb7eceb132dffc9e14e502 Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Tue, 8 Jan 2019 18:03:42 -0800 Subject: [PATCH] test(ivy): updating root causes for tests within @angular/core (#28003) The problem that `fixmeIvy`s refer to is resolved, but the tests are still broken due to other issue (not possible to retrieve host property bindings for DebugElement). PR Close #28003 --- packages/core/test/linker/ng_module_integration_spec.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core/test/linker/ng_module_integration_spec.ts b/packages/core/test/linker/ng_module_integration_spec.ts index de680d08fe..239f415a99 100644 --- a/packages/core/test/linker/ng_module_integration_spec.ts +++ b/packages/core/test/linker/ng_module_integration_spec.ts @@ -486,7 +486,7 @@ function declareTests(config?: {useJit: boolean}) { describe('import/export', () => { - fixmeIvy('FW-756: Pipes and directives from imported modules are not taken into account') + fixmeIvy('FW-681: not possible to retrieve host property bindings from TView') .it('should support exported directives and pipes', () => { @NgModule( {declarations: [SomeDirective, SomePipe], exports: [SomeDirective, SomePipe]}) @@ -508,7 +508,7 @@ function declareTests(config?: {useJit: boolean}) { .toBe('transformed someValue'); }); - fixmeIvy('FW-756: Pipes and directives from imported modules are not taken into account') + fixmeIvy('FW-681: not possible to retrieve host property bindings from TView') .it('should support exported directives and pipes if the module is wrapped into an `ModuleWithProviders`', () => { @NgModule( @@ -531,7 +531,7 @@ function declareTests(config?: {useJit: boolean}) { .toBe('transformed someValue'); }); - fixmeIvy('FW-756: Pipes and directives from imported modules are not taken into account') + fixmeIvy('FW-681: not possible to retrieve host property bindings from TView') .it('should support reexported modules', () => { @NgModule( {declarations: [SomeDirective, SomePipe], exports: [SomeDirective, SomePipe]}) @@ -556,7 +556,7 @@ function declareTests(config?: {useJit: boolean}) { .toBe('transformed someValue'); }); - fixmeIvy('FW-756: Pipes and directives from imported modules are not taken into account') + fixmeIvy('FW-681: not possible to retrieve host property bindings from TView') .it('should support exporting individual directives of an imported module', () => { @NgModule( {declarations: [SomeDirective, SomePipe], exports: [SomeDirective, SomePipe]})