From 7421534873b739b22409aa97ed565783974ce701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Thu, 17 Jan 2019 11:29:49 -0800 Subject: [PATCH] test(ivy): move error-handling test to be handled at a later stage (#28212) Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime. Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors. Jira Issue: FW-952 PR Close #28212 --- packages/core/test/animation/animation_integration_spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/test/animation/animation_integration_spec.ts b/packages/core/test/animation/animation_integration_spec.ts index 035df4a223..590c254b17 100644 --- a/packages/core/test/animation/animation_integration_spec.ts +++ b/packages/core/test/animation/animation_integration_spec.ts @@ -13,7 +13,7 @@ import {TestBed, fakeAsync, flushMicrotasks} from '@angular/core/testing'; import {ɵDomRendererFactory2} from '@angular/platform-browser'; import {ANIMATION_MODULE_TYPE, BrowserAnimationsModule, NoopAnimationsModule} from '@angular/platform-browser/animations'; import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter'; -import {fixmeIvy, ivyEnabled} from '@angular/private/testing'; +import {ivyEnabled, modifiedInIvy} from '@angular/private/testing'; const DEFAULT_NAMESPACE_ID = 'id'; const DEFAULT_COMPONENT_ID = '1'; @@ -3660,7 +3660,7 @@ const DEFAULT_COMPONENT_ID = '1'; expect(() => { TestBed.createComponent(Cmp); }).not.toThrowError(); }); - fixmeIvy('FW-952 - Error recovery is handled differently in Ivy than VE') + modifiedInIvy('FW-952 - Error recovery is handled differently in Ivy than VE') .it('should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway', () => { @Component({