cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "feat(dart): Add a dev-mode check for undeclared lifecycle interfaces"

Browse Source 
This reverts commit a3d7629134.

Needs co-ordination with google3 changes.
This commit is contained in:
Vikram Subramanian
2016-03-03 18:00:18 -08:00
parent 579b890446
commit 7455b907d1
2 changed files with 3 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
modules/angular2/test/core/reflection/reflector_spec.ts
View File

@ -7,7 +7,6 @@ import {
beforeEach,
browserDetection
} from 'angular2/testing_internal';
import {OnInit} from 'angular2/core';
import {Reflector, ReflectionInfo} from 'angular2/src/core/reflection/reflection';
import {ReflectionCapabilities} from 'angular2/src/core/reflection/reflection_capabilities';
import {
@ -66,19 +65,6 @@ class SuperClassImplementingInterface implements Interface2 {}
class ClassImplementingInterface extends SuperClassImplementingInterface implements Interface {}
// Classes used to test our runtime check for classes that implement lifecycle interfaces but do not
// declare them.
// See https://github.com/angular/angular/pull/6879 and https://goo.gl/b07Kii for details.
class ClassDoesNotDeclareOnInit {
ngOnInit() {}
}
class SuperClassImplementingOnInit implements OnInit {
ngOnInit() {}
}
class SubClassDoesNotDeclareOnInit extends SuperClassImplementingOnInit {}
export function main() {
describe('Reflector', () => {
var reflector;
@ -228,14 +214,6 @@ export function main() {
var p = reflector.interfaces(ClassWithDecorators);
expect(p).toEqual([]);
});
it("should throw for undeclared lifecycle interfaces",
() => { expect(() => reflector.interfaces(ClassDoesNotDeclareOnInit)).toThrowError(); });
it("should throw for class inheriting a lifecycle impl and not declaring the interface",
() => {
expect(() => reflector.interfaces(SubClassDoesNotDeclareOnInit)).toThrowError();
});
});
}