cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): ngcc - no need to pass isCore explicitly (#30591)

Browse Source 
It is part of `EntryPointBundle` so we can just use that, which
is generally already passed around.

PR Close #30591
This commit is contained in:
Pete Bacon Darwin
2019-05-25 20:38:33 +01:00
committed by Kara Erickson
parent e943859843
commit 74f637f98d
5 changed files with 26 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler-cli/ngcc/src/rendering/dts_renderer.ts
View File

@ -53,8 +53,7 @@ export interface DtsClassInfo {
export class DtsRenderer {
constructor(
private dtsFormatter: RenderingFormatter, private fs: FileSystem, private logger: Logger,
private host: NgccReflectionHost, private isCore: boolean, private bundle: EntryPointBundle) {
}
private host: NgccReflectionHost, private bundle: EntryPointBundle) {}
renderProgram(
decorationAnalyses: DecorationAnalyses,
@ -84,7 +83,8 @@ export class DtsRenderer {
const outputText = new MagicString(input.source);
const printer = ts.createPrinter();
const importManager = new ImportManager(
getImportRewriter(this.bundle.dts !.r3SymbolsFile, this.isCore, false), IMPORT_PREFIX);
getImportRewriter(this.bundle.dts !.r3SymbolsFile, this.bundle.isCore, false),
IMPORT_PREFIX);
renderInfo.classInfo.forEach(dtsClass => {
const endOfClass = dtsClass.dtsDeclaration.getEnd();

7
packages/compiler-cli/ngcc/src/rendering/renderer.ts
View File

@ -15,7 +15,6 @@ import {PrivateDeclarationsAnalyses} from '../analysis/private_declarations_anal
import {SwitchMarkerAnalyses, SwitchMarkerAnalysis} from '../analysis/switch_marker_analyzer';
import {IMPORT_PREFIX} from '../constants';
import {FileSystem} from '../../../src/ngtsc/file_system';
import {NgccReflectionHost} from '../host/ngcc_host';
import {EntryPointBundle} from '../packages/entry_point_bundle';
import {Logger} from '../logging/logger';
import {FileToWrite, getImportRewriter, stripExtension} from './utils';
@ -31,8 +30,7 @@ import {extractSourceMap, renderSourceAndMap} from './source_maps';
export class Renderer {
constructor(
private srcFormatter: RenderingFormatter, private fs: FileSystem, private logger: Logger,
private host: NgccReflectionHost, private isCore: boolean, private bundle: EntryPointBundle) {
}
private bundle: EntryPointBundle) {}
renderProgram(
decorationAnalyses: DecorationAnalyses, switchMarkerAnalyses: SwitchMarkerAnalyses,
@ -72,7 +70,8 @@ export class Renderer {
}
const importManager = new ImportManager(
getImportRewriter(this.bundle.src.r3SymbolsFile, this.isCore, this.bundle.isFlatCore),
getImportRewriter(
this.bundle.src.r3SymbolsFile, this.bundle.isCore, this.bundle.isFlatCore),
IMPORT_PREFIX);
if (compiledFile) {