From 76144f156c94b7ad56012e5f7978cdf0764284e2 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Wed, 23 Jan 2019 00:33:41 +0200 Subject: [PATCH] test(docs-infra): properly report errors if `page.init()` fails/rejects (#28290) For asynchronous callbacks, this can be done either by calling `done.fail()` or by returning the promise directly (without requesting a `done` callback). (Using the latter, because it is shorter.) PR Close #28290 --- aio/tests/deployment/e2e/redirection.e2e-spec.ts | 2 +- aio/tests/deployment/e2e/smoke-tests.e2e-spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/aio/tests/deployment/e2e/redirection.e2e-spec.ts b/aio/tests/deployment/e2e/redirection.e2e-spec.ts index 1bb8be51a3..0a71249f54 100644 --- a/aio/tests/deployment/e2e/redirection.e2e-spec.ts +++ b/aio/tests/deployment/e2e/redirection.e2e-spec.ts @@ -7,7 +7,7 @@ describe(browser.baseUrl, () => { const stripQuery = (url: string) => url.replace(/\?.*$/, ''); const stripTrailingSlash = (url: string) => url.replace(/\/$/, ''); - beforeAll(done => page.init().then(done)); + beforeAll(() => page.init()); beforeEach(() => browser.waitForAngularEnabled(false)); afterEach(() => browser.waitForAngularEnabled(true)); diff --git a/aio/tests/deployment/e2e/smoke-tests.e2e-spec.ts b/aio/tests/deployment/e2e/smoke-tests.e2e-spec.ts index 5d05cebd91..01efe85636 100644 --- a/aio/tests/deployment/e2e/smoke-tests.e2e-spec.ts +++ b/aio/tests/deployment/e2e/smoke-tests.e2e-spec.ts @@ -4,7 +4,7 @@ import { SitePage } from './site.po'; describe(browser.baseUrl, () => { const page = new SitePage(); - beforeAll(done => page.init().then(done)); + beforeAll(() => page.init()); beforeEach(() => browser.waitForAngularEnabled(false)); afterEach(() => browser.waitForAngularEnabled(true));