cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): rename "blacklist" to "blocklist" (#28536)

Browse Source 
PR Close #28536
This commit is contained in:
Matias Niemelä
2019-02-05 10:48:18 -08:00
parent 9ef8d2b823
commit 76a6eacb4e
5 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/material-ci/angular_material_test_blacklist.js → tools/material-ci/angular_material_test_blocklist.js vendored
View File

@ -7,8 +7,8 @@
*/
/**
* Blacklist of unit tests from angular/material2 with ivy that are skipped when running on
* angular/angular. As bugs are resolved, items should be removed from this blacklist.
* Blocklist of unit tests from angular/material2 with ivy that are skipped when running on
* angular/angular. As bugs are resolved, items should be removed from this blocklist.
*
* The `notes` section should be used to keep track of specific issues associated with the failures.
*/
@ -16,7 +16,7 @@
// clang-format off
// tslint:disable
window.testBlacklist = {
window.testBlocklist = {
"Portals CdkPortalOutlet should load a template into the portal": {
"error": "TypeError: Cannot read property 'createEmbeddedView' of undefined",
"notes": "Unknown"

14
tools/material-ci/instructions.md
View File

@ -1,9 +1,9 @@
### Unit tests for Angular CDK/Material
The unit tests from angular/material2 run on CircleCI under the `material-unit-tests` job.
Known failing tests are skipped based on the blacklist in
`tools/material-ci/angular_material_test_blacklist.js`. Whenever the root cause of a known failure
Known failing tests are skipped based on the blocklist in
`tools/material-ci/angular_material_test_blocklist.js`. Whenever the root cause of a known failure
is identified, the `notes` field for the corresponding tests should be updated. Whenever a failure
is resolved, the corresponding tests should be removed from the blacklist.
is resolved, the corresponding tests should be removed from the blocklist.
### Debugging
To debug a failure, you need to work against the angular/material2 repo:
@ -13,12 +13,12 @@ To debug a failure, you need to work against the angular/material2 repo:
4. Run `scripts/ivy/install-angular.sh path/to/local/angular/repo`
5. Run `gulp test`
### Regenerating the blacklist
If a problem has been fixed, you can regenerate the blacklist by:
### Regenerating the blocklist
If a problem has been fixed, you can regenerate the blocklist by:
1. Clone `angular/material2`
2. Checkout the `ivy-2019` branch
3. Run `yarn`
4. Run `scripts/ivy/install-angular.sh path/to/local/angular/repo`
5. Run `gulp test`. Let it finish. It will take a few minutes.
6. Run `scripts/ivy/generate-blacklist.js`
7. Copy the new blacklist from `dist/angular_material_test_blacklist.js`
6. Run `scripts/ivy/generate-blocklist.js`
7. Copy the new blocklist from `dist/angular_material_test_blocklist.js`